Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: fix default cluster from navigation. #1296

Merged
merged 2 commits into from
Aug 19, 2020

Conversation

Gerhut
Copy link
Member

@Gerhut Gerhut commented Aug 18, 2020

If user navigate to job submission by clicking the submit job button in resource card in home page, the default cluster should be set to the cluster the button belongs to.

@Gerhut Gerhut requested a review from Anbang-Hu August 18, 2020 15:09
@coveralls
Copy link

coveralls commented Aug 18, 2020

Pull Request Test Coverage Report for Build 3801

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.21%

Totals Coverage Status
Change from base Build 3794: 0.0%
Covered Lines: 986
Relevant Lines: 1058

💛 - Coveralls

@Gerhut Gerhut merged commit 5a28a1e into microsoft:dltsdev Aug 19, 2020
@Gerhut Gerhut deleted the dashboard/submission/default-cluster branch August 19, 2020 00:46
Gerhut added a commit to Gerhut/DLWorkspace that referenced this pull request Aug 19, 2020
* Dashboard: fix default cluster from navigation.

* use hook in training job submission
Gerhut added a commit that referenced this pull request Aug 19, 2020
* Dashboard: fix default cluster from navigation.

* use hook in training job submission
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants