Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make optimizer field optional in JSON config #16

Closed
tjruwase opened this issue Feb 5, 2020 · 0 comments · Fixed by #24
Closed

Make optimizer field optional in JSON config #16

tjruwase opened this issue Feb 5, 2020 · 0 comments · Fixed by #24
Assignees
Labels
bug Something isn't working

Comments

@tjruwase
Copy link
Contributor

tjruwase commented Feb 5, 2020

Missing optimizer field causes a crash, even though optimizer field is supposed to be optional.

@jeffra jeffra added the bug Something isn't working label Feb 5, 2020
@tjruwase tjruwase linked a pull request Feb 5, 2020 that will close this issue
rraminen pushed a commit to rraminen/DeepSpeed that referenced this issue Apr 28, 2021
rraminen pushed a commit to rraminen/DeepSpeed that referenced this issue Apr 28, 2021
Co-authored-by: Elton Zheng <eltonz@microsoft.com>
liamcli pushed a commit to determined-ai/DeepSpeed that referenced this issue Sep 27, 2021
* update default configs

* fix bug with onebitadam + p.p hanging

* send tensors to cuda

* autodetect nvlink pairs and remap cuda visible devices

Co-authored-by: sid <sidney.black@aleph-alpha.de>
bobowwb added a commit to bobowwb/DeepSpeed that referenced this issue Apr 19, 2023
line 98 should be
curl -O https://bootstrap.pypa.io/pip/3.6/get-pip.py && \
to avoid
microsoft#16 106.9 ERROR: This script does not work on Python 3.6 The minimum supported Python version is 3.7. Please use https://bootstrap.pypa.io/pip/3.6/get-pip.py instead.
loadams added a commit that referenced this issue Apr 20, 2023
line 98 should be
curl -O https://bootstrap.pypa.io/pip/3.6/get-pip.py && \
to avoid
#16 106.9 ERROR: This script does not work on Python 3.6 The minimum supported Python version is 3.7. Please use https://bootstrap.pypa.io/pip/3.6/get-pip.py instead.

Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
Liangliang-Ma referenced this issue in Liangliang-Ma/DeepSpeed Nov 6, 2023
* Reuse hf_model list among tests to avoid slow loading

* try to debug test skip

* another attempt to print test failure

* another attempt

* more attempt to print skip reason

* revert changes that are temporary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants