Align optimizer swap buffer sizes #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimizer swap buffer sizes should be aligned
tjruwase
requested review from
arashashari,
awan-10,
cli99,
conglongli,
eltonzheng,
minjiaz,
niumanar,
RezaYazdaniAminabadi and
ShadenSmith
as code owners
…Speed into olruwase/nvme_offload_bug
|
Added fix for #1037. |
samyam
approved these changes
May 5, 2021
jeffra
approved these changes
May 5, 2021
|
This doesn't quite fix #1037 though. The problem is that the warning is not matching the traceback in its appearance in the log - sometimes it appears after the crash - these are 2 different streams. So it's very difficult to see and make a correlation with the JIT crash. This needs to be an assert, IMHO - and not a warning. For some reason I'm not allowed to re-open the Issue I created - odd. |
|
@stas00, good point. I have re-opened the issue. I think we require a more general solution because assert is heavy-weight in some cases. But I agree we need to make the failure messages more meaningful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizer swap buffer sizes should be aligned, fix for #1033.
NVMe intra-request validation should be on entire file.