Support iterators with incompletely defined __len__ functions #2445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codedecde
requested review from
jeffra,
samyam,
tjruwase,
ShadenSmith,
conglongli,
awan-10,
cli99,
eltonzheng,
minjiaz,
RezaYazdaniAminabadi,
duli2012,
mrwyattii,
yaozhewei,
arashb,
xiaoxiawu-microsoft,
samadejacobs,
cmikeh2 and
GuanhuaWang
as code owners
tjruwase
reviewed
Oct 25, 2022
|
@codedecde - is this still a bug that you'd like to see fixed and is this PR complete from your side or do you need to push additional changes? Apologies for getting back around to this, but we can review if this is still a problem. |
loadams
removed request for
arashb,
ShadenSmith,
cmikeh2,
duli2012,
samyam and
conglongli
loadams
removed request for
awan-10,
GuanhuaWang,
samadejacobs,
cli99,
yaozhewei,
eltonzheng,
minjiaz,
RezaYazdaniAminabadi and
xiaoxiawu-microsoft
loadams
changed the title
tjruwase
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If data_iter has an incomplete definition of len, this would throw an error with the check. But as long as the iter function works correctly, the semantics of the data_iterator are unaffected. Making the check more explicit for handling this.