Fix racing condition in GatheredParameters #3819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeyangQin
requested review from
jeffra,
tjruwase,
samyam and
mrwyattii
as code owners
lekurile
approved these changes
Jun 26, 2023
…soft/DeepSpeed into HeyangQin/fix_issue_dse337
…soft/DeepSpeed into HeyangQin/fix_issue_dse337
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GatheredParameters DeepSpeed/deepspeed/runtime/zero/partition_parameters.py at master · microsoft/DeepSpeed · GitHub doesn't check if the input params are duplicate or not. And from the hybrid engine side, it is passing duplicate parameters DeepSpeed/deepspeed/runtime/hybrid_engine.py at master · microsoft/DeepSpeed · GitHub. This is causing a racing condition and then potentially causes all kinds of "INFLIGHT" issues like #3068 #3156
#3735
microsoft/DeepSpeedExamples#337
microsoft/DeepSpeedExamples#591.
This PR fixes this issue