Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to select name of .deepspeed_env #4006

Merged
merged 8 commits into from
Jul 20, 2023
Merged

Conversation

loadams
Copy link
Contributor

@loadams loadams commented Jul 20, 2023

  • Allow the user to override the default name of .deepspeed_env to their own, so they can run multiple jobs at the same time.
  • Sample logging output:
[2023-07-20 22:40:02,073] [INFO] [runner.py:561:main] deepspeed_env file = /home/aiscuser/logan/.deepspeed_logan_env

@loadams loadams linked an issue Jul 20, 2023 that may be closed by this pull request
@loadams loadams requested a review from mrwyattii as a code owner July 20, 2023 19:04
@loadams loadams added this pull request to the merge queue Jul 20, 2023
Merged via the queue into master with commit 6580a2d Jul 20, 2023
16 checks passed
@jeffra jeffra mentioned this pull request Jan 23, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jan 23, 2024
When there exist two `.deepspeed_env` files (e.g., at `~/.deepspeed_env`
and `./.deepspeed_env`), only the local version will be read and used.
The behavior changed with the support of `$DS_ENV`
(#4006). This PR allows
multuple `.deepspeed_env` files from all the
`DEEPSPEED_ENVIRONMENT_PATHS` paths to be read and used when launching.

/cc @loadams @mrwyattii
mauryaavinash95 pushed a commit to mauryaavinash95/DeepSpeed that referenced this pull request Feb 17, 2024
When there exist two `.deepspeed_env` files (e.g., at `~/.deepspeed_env`
and `./.deepspeed_env`), only the local version will be read and used.
The behavior changed with the support of `$DS_ENV`
(microsoft#4006). This PR allows
multuple `.deepspeed_env` files from all the
`DEEPSPEED_ENVIRONMENT_PATHS` paths to be read and used when launching.

/cc @loadams @mrwyattii
@loadams loadams deleted the loadams/dot-deepspeed_env branch February 28, 2024 18:15
rraminen pushed a commit to ROCm/DeepSpeed that referenced this pull request May 9, 2024
When there exist two `.deepspeed_env` files (e.g., at `~/.deepspeed_env`
and `./.deepspeed_env`), only the local version will be read and used.
The behavior changed with the support of `$DS_ENV`
(microsoft#4006). This PR allows
multuple `.deepspeed_env` files from all the
`DEEPSPEED_ENVIRONMENT_PATHS` paths to be read and used when launching.

/cc @loadams @mrwyattii
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQUEST] Allow custom location for .deepspeed_env
2 participants