Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove duplicate check for pp and zero stage #4033

Merged
merged 4 commits into from
Jul 25, 2023
Merged

remove duplicate check for pp and zero stage #4033

merged 4 commits into from
Jul 25, 2023

Conversation

inkcherry
Copy link
Contributor

duplicate with

DeepSpeed/deepspeed/runtime/pipe/engine.py

Line 58 in f3943cf

assert self.zero_optimization_stage() < 2, "ZeRO-2 and ZeRO-3 are incompatible with pipeline parallelism"

no need to check again.

@tjruwase
Copy link
Contributor

@inkcherry, thanks for this PR. Do you mind replacing the 2 in the assert with ZeroStageEnum.gradients? Thanks!

@mrwyattii mrwyattii enabled auto-merge July 25, 2023 16:59
@mrwyattii mrwyattii added this pull request to the merge queue Jul 25, 2023
Merged via the queue into microsoft:master with commit e8600b7 Jul 25, 2023
16 checks passed
@delock delock mentioned this pull request Sep 20, 2024
Open
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjruwase tjruwase tjruwase approved these changes

@ShadenSmith ShadenSmith Awaiting requested review from ShadenSmith

@duli2012 duli2012 Awaiting requested review from duli2012

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@inkcherry @tjruwase @abhilash1910 @mrwyattii