Make the location map run per entry point #6688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code that addes the input and output decoration in the entry points inputs and outputs assumes that there is a single entry point in the module. When using the `lib` profile that is not true. This commit modifies the code so that it groups the stage variables by entry point, and runs the current code on each group separetly. I hesistate to make this change because it will change the locations for code that currently works, and will force users to update their applications accordingly. Or they could modify their shaders to use explicit locations attributes. Neither is great. Fixes microsoft#6678 Fixes microsoft#5213
cassiebeckley
approved these changes
Jun 12, 2024
Keenuts
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code that adds the input and output decoration in the entry points
inputs and outputs assumes that there is a single entry point in the
module. When using the
libprofile that is not true.This commit modifies the code so that it groups the stage variables by
entry point, and runs the current code on each group separably.
I hesitate to make this change because it will change the locations for
code that currently works, and will force users to update their
applications accordingly. Or they could modify their shaders
to use explicit locations attributes. Neither is great.
However, the advantage is that this allows the implicit locations to match what would happen if the shader were compiled individually. It also makes the locations more predictable because change in another shader would change all shader after it. This is a better design, and worth the breakage.
Fixes #6678
Fixes #5213