Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make multiline languages configurable #1149

Merged
merged 6 commits into from
Jan 11, 2024
Merged

Conversation

pfrcks
Copy link
Contributor

@pfrcks pfrcks commented Jan 10, 2024

  • makes .NET optional. Default now is Go, Python and Java
  • Customers can override defaults by using stacktrace_languages option in configmap to select the languages they want to use

@pfrcks pfrcks requested a review from a team as a code owner January 10, 2024 18:53
ganga1980
ganga1980 previously approved these changes Jan 10, 2024
wanlonghenry
wanlonghenry previously approved these changes Jan 10, 2024
@pfrcks pfrcks dismissed stale reviews from wanlonghenry and ganga1980 via ca1f4fd January 11, 2024 00:45
@pfrcks
Copy link
Contributor Author

pfrcks commented Jan 11, 2024

tested scenarios

  1. cluster on image with these changes and no configmap -> same as before
  2. cluster on image with these changes and old configmap (without stacktrace_languages option) -> same as before all languages enabled
  3. cluster on image with these changes and new configmap (one language, multiple languages) -> only specified languages enabled
  4. cluster on image with these changes and new configmap (stacktrace_languages = []) -> stacktrace disabled, only cri/docker enabled
  5. cluster on image with these changes and new configmap (stacktrace_languages = ["invalid"]) -> stacktrace disabled, only cri/docker enabled

@pfrcks pfrcks merged commit ef7f4a0 into ci_prod Jan 11, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants