Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go and telegraf #1244

Closed
wants to merge 11 commits into from
Closed

Conversation

pfrcks
Copy link
Contributor

@pfrcks pfrcks commented May 8, 2024

This pull request primarily focuses on updating various dependencies and versions in the codebase. The most significant changes include updating the Go version used in GitHub Actions and in the go.mod files, updating the ignored vulnerabilities in the .trivyignore file, and updating the Telegraf version in both Linux and Windows setup scripts.

Version updates:

  • .github/workflows/run_unit_tests.yml: Updated the Go version used in GitHub Actions from 1.19.x to 1.22.x.
  • source/plugins/go/input/go.mod and source/plugins/go/src/go.mod: Updated the Go version from 1.19 to 1.22 in these go.mod files. [1] [2]

Vulnerability management:

  • .trivyignore: Updated the list of ignored vulnerabilities, removing some and adding others.

Telegraf version updates:

@pfrcks pfrcks requested a review from a team as a code owner May 8, 2024 17:54
@pfrcks pfrcks force-pushed the user/amagraw/fix-vulns/golang/1 branch from c51def4 to 5e3f889 Compare May 8, 2024 17:55
@@ -42,7 +42,7 @@ Write-Host ('Finished Installing Fluentbit')
Write-Host ('Installing Telegraf');
try {
# For next telegraf update, make sure to update config changes in telegraf.conf, tomlparser-prom-customconfig.rb and tomlparser-osm-config.rb
$telegrafUri='https://dl.influxdata.com/telegraf/releases/telegraf-1.24.2_windows_amd64.zip'
$telegrafUri='https://dl.influxdata.com/telegraf/releases/telegraf-1.29.4_windows_amd64.zip'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this version working? in the past, we had issues with telegraf update on windows hence we didnt upgrade the version.

@@ -59,7 +59,7 @@ sudo tdnf install jq-1.6-1.cm2 -y
#used to setcaps for ruby process to read /proc/env
sudo tdnf install libcap -y

sudo tdnf install telegraf-1.28.5 -y
sudo tdnf install telegraf-1.29.4 -y
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please validate the perf and functional tests for this update, and also review any issues on this telegraf version related to promethus, disk, diskio plugins.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lot of work to individually test all this. I was hoping to use CI/CD clusters for this. WDYT?

Copy link
Contributor

@ganga1980 ganga1980 May 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lot of work to individually test all this. I was hoping to use CI/CD clusters for this. WDYT?

Can you please run some basic tests on both Linux and Windows to ensure this doesnt have any breaking change before we validate on CI/CD clusters. Primarily for windows, we have seen issues when we upgraded telegraf.

@pfrcks pfrcks force-pushed the user/amagraw/fix-vulns/golang/1 branch from 003028f to ca1c4e5 Compare May 9, 2024 18:37
Copy link

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants