-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update go and telegraf #1244
update go and telegraf #1244
Conversation
c51def4
to
5e3f889
Compare
@@ -42,7 +42,7 @@ Write-Host ('Finished Installing Fluentbit') | |||
Write-Host ('Installing Telegraf'); | |||
try { | |||
# For next telegraf update, make sure to update config changes in telegraf.conf, tomlparser-prom-customconfig.rb and tomlparser-osm-config.rb | |||
$telegrafUri='https://dl.influxdata.com/telegraf/releases/telegraf-1.24.2_windows_amd64.zip' | |||
$telegrafUri='https://dl.influxdata.com/telegraf/releases/telegraf-1.29.4_windows_amd64.zip' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this version working? in the past, we had issues with telegraf update on windows hence we didnt upgrade the version.
@@ -59,7 +59,7 @@ sudo tdnf install jq-1.6-1.cm2 -y | |||
#used to setcaps for ruby process to read /proc/env | |||
sudo tdnf install libcap -y | |||
|
|||
sudo tdnf install telegraf-1.28.5 -y | |||
sudo tdnf install telegraf-1.29.4 -y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please validate the perf and functional tests for this update, and also review any issues on this telegraf version related to promethus, disk, diskio plugins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lot of work to individually test all this. I was hoping to use CI/CD clusters for this. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lot of work to individually test all this. I was hoping to use CI/CD clusters for this. WDYT?
Can you please run some basic tests on both Linux and Windows to ensure this doesnt have any breaking change before we validate on CI/CD clusters. Primarily for windows, we have seen issues when we upgraded telegraf.
003028f
to
ca1c4e5
Compare
This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This pull request primarily focuses on updating various dependencies and versions in the codebase. The most significant changes include updating the Go version used in GitHub Actions and in the
go.mod
files, updating the ignored vulnerabilities in the.trivyignore
file, and updating the Telegraf version in both Linux and Windows setup scripts.Version updates:
.github/workflows/run_unit_tests.yml
: Updated the Go version used in GitHub Actions from 1.19.x to 1.22.x.source/plugins/go/input/go.mod
andsource/plugins/go/src/go.mod
: Updated the Go version from 1.19 to 1.22 in thesego.mod
files. [1] [2]Vulnerability management:
.trivyignore
: Updated the list of ignored vulnerabilities, removing some and adding others.Telegraf version updates:
kubernetes/linux/setup.sh
: Updated the Telegraf version from 1.28.5 to 1.29.4 in the Linux setup script.kubernetes/windows/setup.ps1
: Updated the Telegraf download link to point to version 1.29.4 instead of 1.24.2 in the Windows setup script.