Object log recovery fixes #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We also add an option to enable file buffering for the storage device, and ensure that during recovery, we only load records from HeadAddress onwards into main memory. |
badrishc
requested review from
peterfreiling-zz
and removed request for
peterfreiling-zz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for reading records in the presence of an object log was writing directly to a pinned array of managed objects, to avoid fine grained copy of parts of the log that are not managed. However, this solution has problems in the presence of GC. This checkin primarily undoes this optimization for the sake of correctness. There are a few other minor improvements, such as using a SafeConcurrentDictionary to store file handles, to avoid spurious creation when many threads read in parallel.