Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_nan filter issue #458

Open
JSpinks93 opened this issue Mar 3, 2023 · 0 comments
Open

is_nan filter issue #458

JSpinks93 opened this issue Mar 3, 2023 · 0 comments

Comments

@JSpinks93
Copy link

The documentation calls out 'is_nan' as a filter. The example given is:

image

After doing some testing with this it seems to actually use the filter in liquid you would have to write the filter as 'in_na_n'. Using 'is_nan' results in the variable you are checking being returned as the result since it doesn't seem to be recognized as a valid filter.

I'm not sure what is converting the dotnet method to a filter, but it seems to key off of casing. Since the method is named 'IsNaN' I think that's resulting in the liquid filter being named 'is_na_n'. If the method were named 'IsNan' I think the filter would then match the documentation.

image

Also the result of the filter seems to be reversed, things that are numbers are returning 'true' and things that are not numbers are returning 'false'. Below is the code I used to test, and the output.

Liquid code:
image

Json output:
image

JSpinks93 added a commit to JSpinks93/FHIR-Converter that referenced this issue Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant