Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md for JSON to FHIR #324

Merged
merged 9 commits into from
Dec 13, 2021
Merged

Update README.md for JSON to FHIR #324

merged 9 commits into from
Dec 13, 2021

Conversation

ginalee-dotcom
Copy link
Contributor

No description provided.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@qiwjin qiwjin requested a review from sowu880 October 12, 2021 06:51
README.md Outdated
```
>.\Microsoft.Health.Fhir.Liquid.Converter.Tool.exe convert -d myTemplateDirectory -r myRootTemplate -i myInputDataFolder -o myOutputDataFolder
>.\Microsoft.Health.Fhir.Liquid.Converter.Tool.exe convert -n {path}\SampleData\Json\Stu3ChargeItem.json -d {path}\Templates\Json -f {output_path}\Stu3ChargeItem.json -r Stu3ChargeItem
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also update the sample output below. Since the screenshot is for CCDA.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated it with this sentence: "For example, if you were doing the C-CDA to FHIR conversion, you will see something like this:"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If using CCDA as example, we'd better update the command line sample here to keep consistent.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the command should keep the same with the screenshot.

@BoyaWu10
Copy link
Contributor

Hi @ginalee-dotcom, is this PR still active?

@BoyaWu10 BoyaWu10 requested a review from qiwjin October 28, 2021 02:02
BoyaWu10
BoyaWu10 previously approved these changes Nov 12, 2021
BoyaWu10
BoyaWu10 previously approved these changes Nov 16, 2021
README.md Outdated Show resolved Hide resolved
BoyaWu10
BoyaWu10 previously approved these changes Nov 23, 2021
@ginalee-dotcom
Copy link
Contributor Author

@qiwjin Is this okay to be merged?

README.md Show resolved Hide resolved
@sowu880 sowu880 merged commit ae582fa into main Dec 13, 2021
@sowu880 sowu880 deleted the ginalee-dotcom-patch-1 branch December 13, 2021 07:19
jasonheld-msft pushed a commit to jasonheld-msft/FHIR-Converter that referenced this pull request Mar 8, 2022
* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update Filters-and-Tags.md

* Update README.md

* Update README.md

* Update README.md
v-shnarang pushed a commit to v-shnarang/FHIR-Converter that referenced this pull request Mar 11, 2022
* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update Filters-and-Tags.md

* Update README.md

* Update README.md

* Update README.md
v-shnarang pushed a commit to v-shnarang/FHIR-Converter that referenced this pull request Mar 14, 2022
* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update Filters-and-Tags.md

* Update README.md

* Update README.md

* Update README.md
sowu880 added a commit that referenced this pull request Apr 6, 2022
* Update README.md for JSON to FHIR  (#324)

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update Filters-and-Tags.md

* Update README.md

* Update README.md

* Update README.md

* update

* update

* update doc

* update doc

Co-authored-by: ginalee-dotcom <68250213+ginalee-dotcom@users.noreply.github.com>
Co-authored-by: yankunhuang-pku <66581117+yankunhuang-pku@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants