admin takeover in group chat #1209
Conversation
sonichi
requested review from
qingyun-wu,
gagb,
LittleLittleCloud and
a team
| @@ -12,6 +12,7 @@ class GroupChat: | |||
| agents: List[Agent] | |||
| messages: List[Dict] | |||
| max_round: int = 10 | |||
| admin_name: str = "Admin" # the name of the admin agent | |||
There was a problem hiding this comment.
Maybe check if admin_name exists here? So you don't need to throw expection in run_chat
There was a problem hiding this comment.
how do we check it "here"?
There was a problem hiding this comment.
My understand is admin_name must be the name of an agent in agents, Otherwise the keyboardInterruption will be raised when human user tries to interrupt group chat?
If my understand is correct it would be better to check if admin_name is legit(a.k.a is one of an agents) in constructor.
There was a problem hiding this comment.
admin_name is optional. There doesn't have to be an admin. Only when there is, we support using KeyboardInterruption to take over.
flaml/autogen/agentchat/groupchat.py
Outdated
| # speaker selection msg from an agent | ||
| speaker = config.select_speaker(speaker, self) | ||
| reply = speaker.generate_reply(sender=self) | ||
| if i != groupchat.max_round - 1: |
There was a problem hiding this comment.
Please add a comment to explain what's being done here?
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Why are these changes needed?
Related issue number
Checks