-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ruff sort to pre-commit and sort imports in the library #1259
Conversation
I almost sure that some tests will start to fail, so there still some work to be done |
Should OpenAI tests also run? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you very much @glevv.
This will be triggered later when approved. |
I'm not sure why OpenAI checks are failing. |
@sonichi could you take a look at this? Thanks. |
@@ -24,6 +24,7 @@ select = [ | |||
# "D", # see: https://pypi.org/project/pydocstyle | |||
# "N", # see: https://pypi.org/project/pep8-naming | |||
# "S", # see: https://pypi.org/project/flake8-bandit | |||
"I", # see: https://pypi.org/project/isort/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the main change; the rest is just apply pre-commit :)
ref: #1252 (comment)
I don't think it is possible to automerge without all the checks being green |
That is right, but |
@sonichi @thinkall @jackgerrits how about adding this bot which would help with all this manual linitng? |
Why are these changes needed?
To maintain clean and lean imports
Related issue number
Closes #1252
Checks