Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruff sort to pre-commit and sort imports in the library #1259

Merged
merged 7 commits into from
Mar 12, 2024

Conversation

glevv
Copy link
Contributor

@glevv glevv commented Dec 2, 2023

Why are these changes needed?

To maintain clean and lean imports

Related issue number

Closes #1252

Checks

@glevv
Copy link
Contributor Author

glevv commented Dec 2, 2023

I almost sure that some tests will start to fail, so there still some work to be done

@glevv
Copy link
Contributor Author

glevv commented Dec 10, 2023

Should OpenAI tests also run?

Copy link
Collaborator

@thinkall thinkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much @glevv.

@thinkall
Copy link
Collaborator

Should OpenAI tests also run?

This will be triggered later when approved.

@glevv
Copy link
Contributor Author

glevv commented Jan 17, 2024

I'm not sure why OpenAI checks are failing.

@thinkall
Copy link
Collaborator

I'm not sure why OpenAI checks are failing.

@sonichi could you take a look at this? Thanks.

@@ -24,6 +24,7 @@ select = [
# "D", # see: https://pypi.org/project/pydocstyle
# "N", # see: https://pypi.org/project/pep8-naming
# "S", # see: https://pypi.org/project/flake8-bandit
"I", # see: https://pypi.org/project/isort/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the main change; the rest is just apply pre-commit :)
ref: #1252 (comment)

@sonichi sonichi added this pull request to the merge queue Feb 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 5, 2024
@glevv
Copy link
Contributor Author

glevv commented Mar 2, 2024

I don't think it is possible to automerge without all the checks being green

@sonichi sonichi enabled auto-merge March 2, 2024 06:21
@Borda
Copy link
Collaborator

Borda commented Mar 2, 2024

I don't think it is possible to automerge without all the checks being green

That is right, but it seems that even all checks on mater are not green it seems some tests are flaky so this will need to wait until main branch is healthy =)

@Borda
Copy link
Collaborator

Borda commented Mar 12, 2024

@sonichi @thinkall @jackgerrits how about adding this bot which would help with all this manual linitng?

@sonichi sonichi added this pull request to the merge queue Mar 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 12, 2024
@sonichi sonichi added this pull request to the merge queue Mar 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 12, 2024
@sonichi sonichi added this pull request to the merge queue Mar 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 12, 2024
@sonichi sonichi added this pull request to the merge queue Mar 12, 2024
Merged via the queue into microsoft:main with commit 3de0dc6 Mar 12, 2024
13 of 16 checks passed
@glevv glevv deleted the ruff-sort branch March 13, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we add isort to the pre-commit?
4 participants