Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

precommit: introduce mdformat #1276

Merged
merged 5 commits into from
Mar 19, 2024
Merged

Conversation

Borda
Copy link
Collaborator

@Borda Borda commented Feb 8, 2024

Why are these changes needed?

This is systematic solution to MD formatting as reported

Related issue number

for example, in #834

Checks

@Borda
Copy link
Collaborator Author

Borda commented Feb 8, 2024

the core change is 14fdf69, and the resulted formatting is in ac6f076

most of the changes are switch list syntax from * ... to - ...

@Borda Borda mentioned this pull request Feb 8, 2024
@Borda Borda added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (550d1cf) 71.61% compared to head (a79e90a) 71.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1276      +/-   ##
==========================================
+ Coverage   71.61%   71.65%   +0.04%     
==========================================
  Files          83       83              
  Lines       11249    11249              
  Branches     2360     2360              
==========================================
+ Hits         8056     8061       +5     
+ Misses       2737     2734       -3     
+ Partials      456      454       -2     
Flag Coverage Δ
unittests 71.53% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Borda
Copy link
Collaborator Author

Borda commented Feb 9, 2024

@sonichi @thinkall, mind check and share your opinion? 🐰

@Borda
Copy link
Collaborator Author

Borda commented Feb 28, 2024

@sonichi @thinkall @jackgerrits, how are you doing? could you have a quick look? 🦩

Copy link
Collaborator

@thinkall thinkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Borda , looks good to me.

@Borda
Copy link
Collaborator Author

Borda commented Mar 19, 2024

@sonichi @jackgerrits, could you pls also have a look? 🐰

@sonichi sonichi added this pull request to the merge queue Mar 19, 2024
Merged via the queue into microsoft:main with commit 165d746 Mar 19, 2024
13 checks passed
@Borda Borda deleted the precommit/mdformat branch March 20, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants