Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate multivariate time series forecasting #254

Merged
merged 104 commits into from
Oct 30, 2021

Conversation

int-chaos
Copy link
Collaborator

@int-chaos int-chaos commented Oct 16, 2021

#204

  • support numerical and categorical features for ts_forecasting
  • update data.py to transform time series data
  • update search space
  • update documentations to reflect changes
  • update test_forecast.py
  • rename 'forecast' task to 'ts_forecast' task

int-chaos and others added 30 commits August 5, 2021 19:04
Signed-off-by: Kevin Chen <chenkevin.8787@gmail.com>
update search space for FBProphet

make 'forecast' depedencies optional

add TimeSeriesSplit to 'regression' and 'classification' task
Signed-off-by: Kevin Chen <chenkevin.8787@gmail.com>

# Conflicts (Resolved):
#	flaml/automl.py
#	flaml/model.py
Signed-off-by: Kevin Chen <chenkevin.8787@gmail.com>
Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Signed-off-by: Kevin Chen <chenkevin.8787@gmail.com>
Signed-off-by: Kevin Chen <chenkevin.8787@gmail.com>
Signed-off-by: Kevin Chen <chenkevin.8787@gmail.com>
Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Signed-off-by: Kevin Chen <chenkevin.8787@gmail.com>
Signed-off-by: Kevin Chen <chenkevin.8787@gmail.com>
Signed-off-by: Kevin Chen <chenkevin.8787@gmail.com>
Signed-off-by: Kevin Chen <chenkevin.8787@gmail.com>
Signed-off-by: Kevin Chen <chenkevin.8787@gmail.com>
Signed-off-by: Kevin Chen <chenkevin.8787@gmail.com>
Signed-off-by: Kevin Chen <chenkevin.8787@gmail.com>
Signed-off-by: Kevin Chen <chenkevin.8787@gmail.com>
@sonichi
Copy link
Contributor

sonichi commented Oct 19, 2021

Please create a new branch from upstream/main before you start working on your next PR to get rid of the old commit history.

Copy link
Collaborator

@slhuang slhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Kevin! I just made a pass, please find some comments below.

flaml/automl.py Outdated Show resolved Hide resolved
flaml/automl.py Show resolved Hide resolved
flaml/model.py Show resolved Hide resolved
notebook/flaml_forecast.ipynb Outdated Show resolved Hide resolved
notebook/flaml_forecast.ipynb Outdated Show resolved Hide resolved
test/test_forecast.py Show resolved Hide resolved
test/test_forecast.py Show resolved Hide resolved
test/test_forecast.py Show resolved Hide resolved
test/test_forecast.py Show resolved Hide resolved
test/test_forecast.py Show resolved Hide resolved
@sonichi sonichi requested a review from a user October 20, 2021 23:52
Copy link
Contributor

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address @slhuang's comments and get her approval.

setup.py Show resolved Hide resolved
Copy link
Contributor

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please request review from @slhuang and get her approval.

flaml/automl.py Outdated Show resolved Hide resolved
flaml/automl.py Outdated Show resolved Hide resolved
flaml/automl.py Outdated Show resolved Hide resolved
flaml/automl.py Outdated Show resolved Hide resolved
Copy link
Contributor

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the lint issues reported by the github action.
./test/test_forecast.py:340:1: E305 expected 2 blank lines after class or function definition, found 1
./flaml/model.py:1018:21: F541 f-string is missing placeholders

Signed-off-by: Kevin Chen <chenkevin.8787@gmail.com>
@sonichi sonichi merged commit 519bfc2 into microsoft:main Oct 30, 2021
@Sandy4321
Copy link

is it ready to use ?
where is link to code example pls

@Sandy4321
Copy link

can it predict this data set
features
color | weight | gender |height |age | target

sequence 1 target is YES
time 1| black 56 m 160 34
time 2| white 77 f 170 54
time 3| yellow 87 m 167 43
time 4| white 55 m 198 72
time 5| white 88 f 176 32 YES

sequence 2 target is NO
time 1| yellow 86 f 120 14
time 2| white 27 m 150 44
time 3| yellow 58 f 156 22 NO

sequence 3 target is YES
time 1| yellow 8 f 177 23
time 2| white 15 m 138 82
time 3| yellow 8 f 177 23
time 4| white 15 m 138 82 YES

etc...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants