"intermediate_results" TypeError: argument of type 'NoneType' is not iterable #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liususan091219
changed the title
sonichi
reviewed
Aug 22, 2022
test/automl/test_classification.py
Outdated
| @@ -391,6 +391,22 @@ def test_sparse_matrix_lr(self): | |||
| print(automl_experiment.best_iteration) | |||
| print(automl_experiment.best_estimator) | |||
|
|
|||
| def test_metric_for_logging_None(self): | |||
| # a test case when search_state.metric_for_logging is None | |||
| import mlflow | |||
There was a problem hiding this comment.
This function won't work here because mlflow is not installed.
You can move the test under test_notebooek_example.py:test_mlflow() where mlflow is installed.
sonichi
reviewed
Aug 22, 2022
test/automl/test_notebook_example.py
Outdated
| with mlflow.start_run(): | ||
| automl = AutoML() | ||
| automl_settings = { | ||
| "time_budget": 1, # in seconds |
There was a problem hiding this comment.
Increase to 2 because in my local test, no model is finished using 1.
sonichi
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When using MLflow, there is a TypeError search.state.metric_for_logging is None
"intermediate_results" TypeError: argument of type 'NoneType' is not iterable
Related issue number
Checks