Fix SARIMAX seasonal_order parameter name in the wrapper #711
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The SARIMAX wrapper passed the seasonal parameters as the
seasonality_order
keyword arg to the statsmodels SARIMAX implementation, whereas the right name isseasonal_order
.As a result, the 4 seasonal order parameters were being ignored by the SARIMAX fitter altogether.
Related issue number
Checks