Fix PercentageFilter inequality bound #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NextDouble() ∈ [0, 1). We use a strict inequality, so a 0% value sporadically returns true as 0⩽0. The fix is to use a non-strict inequality, <. The upper bound still works: 0.999... < 1.
|
Additionally, the CLA GHA didn't appear to trip. This PR is provided as part of my employment with https://github.com/roblox, I have the needed authorization to sign the CLA so please do send me a link to an agreement I can sign! |
|
@neiljohari The license check mentions that all CLA requirements are met. Have you already contributed to other Microsoft repos? |
|
@jimmyca15 Thanks for the super speedy response! I don't believe I have previously contributed, I think this is my first one |
jimmyca15
approved these changes
Dec 3, 2021
|
I took a look. The license check did run. For small enough changes it doesn't prompt CLA sign. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NextDouble() ∈ [0, 1). We use a strict inequality, so a 0% rollout value sporadically returns true as 0⩽0.
The fix is to use a non-strict inequality, <. The upper bound still works: 0.999... < 1.
We noticed this internally because feature flags were occasionally tripping even with 0% rollout. This appears to be the root cause.