Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of commits in runtime code #4691

Closed
Tracked by #4683
, #7347
...
vladsud opened this issue Dec 23, 2020 · 5 comments · Fixed by #9633
Closed
Tracked by #4683
, #7347
...

Get rid of commits in runtime code #4691

vladsud opened this issue Dec 23, 2020 · 5 comments · Fixed by #9633
Assignees
@NicholasCouri
Labels
good first issue Good for newcomers refactor Code refactoring and cleanup
Milestone
March 2022

Comments

@vladsud
Copy link
Contributor

vladsud commented Dec 23, 2020

It would be great to get rid of these concepts from repo:

TreeEntry.Commit
"commit"
ISnapshotTree.commits

Notion of commits in summaries is not used and proposed to be cleaned up here: #4682
@vladsud vladsud added the bug Something isn't working label Dec 23, 2020
@vladsud vladsud added this to the January 2021 milestone Dec 23, 2020
@ghost ghost added the triage label Dec 23, 2020
@curtisman curtisman added refactor Code refactoring and cleanup and removed bug Something isn't working triage labels Jan 7, 2021
@curtisman curtisman modified the milestones: January 2021, Next Jan 8, 2021
@vladsud vladsud added the good first issue Good for newcomers label May 27, 2021
@vladsud
Copy link
Contributor Author

vladsud commented May 27, 2021

I think it should be now easy to do and without complications, so marking as good first issue, but it's worth double checking.

@kenluck2001
Copy link
Contributor

I would like to work on this PR.
It seems can be easily cleaned
TreeEntry.Commit
ISnapshotTree.commits

Not sure how to remove "commit". Looking forward

@kenluck2001 kenluck2001 mentioned this issue Jul 26, 2021
Merged
This was referenced Oct 15, 2021
Open
Open
Merged
Merged
Merged
@ghost ghost added the status: stale label Jan 23, 2022
@ghost
Copy link

ghost commented Jan 23, 2022

This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

@ghost ghost removed the status: stale label Jan 23, 2022
@vladsud vladsud modified the milestones: Next, February 2022 Jan 23, 2022
@vladsud
Copy link
Contributor Author

vladsud commented Jan 23, 2022

@scarlettjlee, can you please glance at this one, since you are looking at tree-based interfaces?
Thanks!

@scarlettjlee scarlettjlee mentioned this issue Feb 3, 2022
Open
12 tasks
@vladsud vladsud mentioned this issue Mar 1, 2022
Closed
11 tasks
@vladsud vladsud assigned NicholasCouri and unassigned scarlettjlee Mar 1, 2022
@vladsud
Copy link
Contributor Author

vladsud commented Mar 1, 2022

This item would require understanding of build and multiple mono-repos. Before jumping in, please talk to Scarlet and / or Andrei, so have better sense of what's involved here.

As part of this work, I'd also love to see if we can remove id from ISnapshotTree.

@NicholasCouri NicholasCouri mentioned this issue Mar 26, 2022
Merged
@NicholasCouri NicholasCouri linked a pull request Mar 28, 2022 that will close this issue
Final client changes for TreeEntry.Commit and ISnapshotTree.commits removal #9633
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NicholasCouri NicholasCouri

Labels
good first issue Good for newcomers refactor Code refactoring and cleanup
Projects
None yet
Milestone
March 2022
6 participants
@kenluck2001 @anthony-murphy @curtisman @NicholasCouri @vladsud @scarlettjlee