Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable codeql workflow #9277

Merged
merged 2 commits into from
Mar 3, 2022
Merged

Enable codeql workflow #9277

merged 2 commits into from
Mar 3, 2022

Conversation

tylerbutler
Copy link
Member

No description provided.

@tylerbutler tylerbutler requested a review from a team as a code owner March 1, 2022 01:51
@github-actions github-actions bot added the area: build Build related issues label Mar 1, 2022
@tylerbutler tylerbutler mentioned this pull request Mar 2, 2022
Closed
7 tasks
@anthony-murphy
Copy link
Contributor

i'm a bit worried about this, as it runs really late, aka only in the pr, so problems could be costly to fix as they are not found in the dev inner loop

@tylerbutler
Copy link
Member Author

i'm a bit worried about this, as it runs really late, aka only in the pr, so problems could be costly to fix as they are not found in the dev inner loop

I agree that this is not ideal. I'm not sure it's possible to run locally, but perhaps in a container. But I don't think we should block on that at the moment. These alerts should not prevent anyone from merging at this point. (It's possible I have made config mistakes here like I did with codeowners, but if so, we'll sort them out quickly.) Before we turn on any actual gates, we'll get answers for this and other questions.

@anthony-murphy
Copy link
Contributor

sounds good. also, what kind of issue will this find. i don't know anything about codeql

@tylerbutler
Copy link
Member Author

The links to example issues keep disappearing, likely because we don't have a baseline in main yet, so I am going to quit chasing them and merge.

@tylerbutler tylerbutler merged commit cdb1cdd into microsoft:main Mar 3, 2022
@tylerbutler tylerbutler deleted the build/codeql branch March 3, 2022 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChumpChief ChumpChief ChumpChief approved these changes

Assignees
No one assigned
Labels
area: build Build related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tylerbutler @anthony-murphy @ChumpChief