Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add schema validator interface and implementation #44

Merged
merged 11 commits into from
Jul 7, 2021
Merged

add schema validator interface and implementation #44

merged 11 commits into from
Jul 7, 2021

Conversation

codemonkeyhhq
Copy link
Collaborator

expose api for schema validation use

@ghost
Copy link

ghost commented Jun 16, 2021 •
edited by codemonkeyhhq
Loading

CLA assistant check
All CLA requirements met.

In reply to: 862609344

In reply to: 862609344

In reply to: 862609344

In reply to: 862609344

In reply to: 862609344

In reply to: 862609344

In reply to: 862609344

In reply to: 862609344

In reply to: 862609344

In reply to: 862609344

In reply to: 862609344

@codemonkeyhhq codemonkeyhhq marked this pull request as ready for review June 18, 2021 16:08
TravisOnGit
TravisOnGit requested changes Jun 18, 2021
View reviewed changes
Copy link
Member

@TravisOnGit TravisOnGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@huahaoqi
modify the api, add GetLinkedJSchemaRules method, modify the validate…
da57792 
… method, remove all apis that don't take rules input and fix tests
TravisOnGit
TravisOnGit reviewed Jul 3, 2021
View reviewed changes
Forge.TreeWalker.UnitTests/test/TreeSchemaValidatorTests.cs Outdated
treeSchemas = new Dictionary<string, ForgeTree>();
treeSchemas.Add("tree1", treeSchema);
treeSchemas.Add("tree2", treeSchema);
treeSchemas.Add("tree3", treeSchema);
Copy link
Member

@TravisOnGit TravisOnGit Jul 3, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rename these:
treeSchema -> forgeTree
treeSchemas -> forgeTreeDictionary #Closed

TravisOnGit
TravisOnGit reviewed Jul 3, 2021
View reviewed changes
Forge.TreeWalker.UnitTests/test/TreeSchemaValidatorTests.cs Outdated
public void TestInitialize()
{
forgeTreeFromPath = Path.Combine(Environment.CurrentDirectory, "test\\ExampleSchemas\\TardigradeSchema.json");
schemaDirectoryPath = Path.Combine(Environment.CurrentDirectory, "test\\ExampleSchemas");
Copy link
Member

@TravisOnGit TravisOnGit Jul 3, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

schemaDirectoryPath

directoryPathToMultipleForgeTree #Closed

TravisOnGit
TravisOnGit reviewed Jul 3, 2021
View reviewed changes
Forge.TreeWalker.UnitTests/test/TreeSchemaValidatorTests.cs Outdated
forgeTreeFromPath = Path.Combine(Environment.CurrentDirectory, "test\\ExampleSchemas\\TardigradeSchema.json");
schemaDirectoryPath = Path.Combine(Environment.CurrentDirectory, "test\\ExampleSchemas");
stringRules = File.ReadAllText(Path.Combine(Environment.CurrentDirectory, "contracts\\ForgeSchemaValidationRules.json"));
rulesForDictionary = File.ReadAllText(Path.Combine(Environment.CurrentDirectory, "contracts\\ForgeSchemaDictionaryValidationRules.json"));
Copy link
Member

@TravisOnGit TravisOnGit Jul 3, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rulesForDictionary

rulesForForgeTreeDictionary #Closed

TravisOnGit
TravisOnGit reviewed Jul 3, 2021
View reviewed changes
Forge.TreeWalker.UnitTests/test/TreeSchemaValidatorTests.cs Outdated
schemaDirectoryPath = Path.Combine(Environment.CurrentDirectory, "test\\ExampleSchemas");
stringRules = File.ReadAllText(Path.Combine(Environment.CurrentDirectory, "contracts\\ForgeSchemaValidationRules.json"));
rulesForDictionary = File.ReadAllText(Path.Combine(Environment.CurrentDirectory, "contracts\\ForgeSchemaDictionaryValidationRules.json"));
linkedRulesForDictionary = ForgeSchemaValidator.GetLinkedJSchemaRules(rulesForDictionary, stringRules, "//ForgeSchemaValidationRules.json");
Copy link
Member

@TravisOnGit TravisOnGit Jul 3, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linkedRulesForDictionary

linkedRulesForForgeTreeDictionary #Closed

TravisOnGit
TravisOnGit approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@TravisOnGit TravisOnGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codemonkeyhhq codemonkeyhhq merged commit d12ed9c into master Jul 7, 2021
@codemonkeyhhq codemonkeyhhq deleted the feature/haoqihuang/addSchemaValidationAPI branch July 7, 2021 07:36
@codemonkeyhhq codemonkeyhhq mentioned this pull request Jul 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TravisOnGit TravisOnGit TravisOnGit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codemonkeyhhq @TravisOnGit @huahaoqi