gsl::copy returns remaining range #422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGitb
force-pushed
the
pr/copy_return_type
branch
from
7a8b3c0
to
acbbc8e
Compare
Closed
|
As this PR needs some overhaul before it can be merged: Is there any interest in merging this in the near future? |
MikeGitb
force-pushed
the
pr/copy_return_type
branch
from
acbbc8e
to
72981fa
Compare
|
I'm a bit late to the this party. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As originally planned for #344,
gsl::copynow returns the remaining destination range.If both source and destination span have a static extent, the result is a new span of static extent. Otherwise a span of dynamic extent is returned.
Additionally, the unit tests are now more fine granular than before. Due to the resulting indentation change I'd recommend viewing the diff of
tests/algorithm_tests.cppwith the-wflag.