Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enableFailingTask flag for enabling exception throwing of gradle plugin task failure. #404

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

olivershen-wow
Copy link
Contributor

@olivershen-wow olivershen-wow commented Mar 29, 2023

Pull Request Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Code compiles correctly with all tests are passed.
  • I've read the contributing guide and followed the recommended practices.
  • Wikis or README have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

If this introduces a breaking change for Hydra Lab users, please describe the impact and migration path.

  • Yes
  • No

Pull Request Description

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Build related changes
  • Refactoring (no functional changes, no api changes)
  • Code style update (formatting, renaming) or Documentation content changes
  • Other (please describe):

A few words to explain your changes:

  • Add enableFailingTask flag for enabling exception throwing of gradle plugin task failure.
  • Upgrade version of plugin to 1.1.6.

How you tested it

Please make sure the change is tested, you can test it by adding UTs, do local test and share the screenshots, etc.
Tested locally with expected output exception:
image

Feature UI screenshots or Technical design diagrams

If this is a relatively large or complex change, kick it off by drawing the tech design with PlantUML and explaining why you chose the solution you did and what alternatives you considered, etc...

…e plugin task failure.

- Upgrade version of plugin to 1.1.6
@olivershen-wow olivershen-wow enabled auto-merge (squash) March 29, 2023 12:26
@olivershen-wow olivershen-wow merged commit a60d901 into main Mar 30, 2023
@olivershen-wow olivershen-wow deleted the user/lsh/fix-task-test-failure-align branch March 30, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants