refactor center onMessage, and create UT #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhou9584
reviewed
Apr 10, 2023
...er/src/test/java/com/microsoft/hydralab/center/service/DeviceAgentManagementServiceTest.java
Outdated
Show resolved
Hide resolved
zhou9584
reviewed
Apr 13, 2023
...er/src/test/java/com/microsoft/hydralab/center/service/DeviceAgentManagementServiceTest.java
Outdated
Show resolved
Hide resolved
…iceAgentManagementServiceTest.java Co-authored-by: Le Zhou <2428499107@qq.com>
|
@zhou9584 could you help review this PR when it's a convenient time for you? Thanks! And thank you so much for helping resolve the UT issue. |
|
LGTM for the rest. |
olivershen-wow
previously approved these changes
Apr 14, 2023
olivershen-wow
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked GitHub issue ID: #
Pull Request Checklist
Does this introduce a breaking change?
If this introduces a breaking change for Hydra Lab users, please describe the impact and migration path.
Pull Request Description
A few words to explain your changes: refactor center onMessage, and create UT
How you tested it
Please make sure the change is tested, you can test it by adding UTs, do local test and share the screenshots, etc.
Please check the type of change your PR introduces:
Feature UI screenshots or Technical design diagrams
If this is a relatively large or complex change, kick it off by drawing the tech design with PlantUML and explaining why you chose the solution you did and what alternatives you considered, etc...