[Fix] Fix undefine parsed data and invalid date #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinghong2233
previously approved these changes
Apr 13, 2023
AC-Phoenix
reviewed
Apr 13, 2023
...src/main/java/com/microsoft/hydralab/performance/parsers/AndroidBatteryInfoResultParser.java
Outdated
Show resolved
Hide resolved
AC-Phoenix
reviewed
Apr 13, 2023
...src/main/java/com/microsoft/hydralab/performance/parsers/AndroidBatteryInfoResultParser.java
Outdated
Show resolved
Hide resolved
…s/AndroidBatteryInfoResultParser.java Co-authored-by: Yang Zhang <394054963@qq.com>
AC-Phoenix
approved these changes
Apr 13, 2023
dinghong2233
approved these changes
Apr 13, 2023
dinghong2233
added a commit
that referenced
this pull request
Apr 13, 2023
* Update pull_request_template.md * [Tech Design UML] Design of agent capability discovery (#422) * Design agent_capability * update uml design * Update agent/doc/UML/agent_device_management_design.puml Co-authored-by: Nathan Bu <370788475@qq.com> * Update agent/doc/UML/agent_device_management_design.puml Co-authored-by: Nathan Bu <370788475@qq.com> * Update agent/doc/UML/agent_device_management_design.puml Co-authored-by: Nathan Bu <370788475@qq.com> * Update agent/doc/UML/agent_device_management_design.puml Co-authored-by: Nathan Bu <370788475@qq.com> * update uml * Update method naming * update desc --------- Co-authored-by: Nathan Bu <370788475@qq.com> * Bump json5 from 1.0.1 to 1.0.2 in /react (#419) Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Fix] Fix undefined parsed data and invalid date (#428) * Fix undefine parsed data and invalid date * Update common/src/main/java/com/microsoft/hydralab/performance/parsers/AndroidBatteryInfoResultParser.java Co-authored-by: Yang Zhang <394054963@qq.com> --------- Co-authored-by: Yang Zhang <394054963@qq.com> * Start WDA proxy if we need ios driver before test start (#426) * Start WDA proxy if we need ios driver before test start * Change some implement for ios device --------- Co-authored-by: Millard <hodin@microsoft.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Nathan Bu <370788475@qq.com> Co-authored-by: Le Zhou <2428499107@qq.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ran Tao <1252026067@qq.com> Co-authored-by: Yang Zhang <394054963@qq.com> Co-authored-by: Millard <hodin@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked GitHub issue ID: #
Pull Request Checklist
Does this introduce a breaking change?
If this introduces a breaking change for Hydra Lab users, please describe the impact and migration path.
Pull Request Description
A few words to explain your changes:
How you tested it
Please make sure the change is tested, you can test it by adding UTs, do local test and share the screenshots, etc.
Trigger E2E performance test and check the test report
Please check the type of change your PR introduces:
Feature UI screenshots or Technical design diagrams
If this is a relatively large or complex change, kick it off by drawing the tech design with PlantUML and explaining why you chose the solution you did and what alternatives you considered, etc...