Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technical design: scan install package of apps #623

Merged
merged 8 commits into from
Dec 19, 2023
Merged

Conversation

zhou9584
Copy link
Contributor

@zhou9584 zhou9584 commented Nov 22, 2023

Description

Design the architecture for APK Scanner. Considering the scalability, we would use some interference of task, result, scanner to implement multiple inheritance.

Linked GitHub issue ID:

Pull Request Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Code compiles correctly with all tests are passed.
  • I've read the contributing guide and followed the recommended practices.
  • Wikis or README have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

If this introduces a breaking change for Hydra Lab users, please describe the impact and migration path.

  • Yes
  • No

How you tested it

Please make sure the change is tested, you can test it by adding UTs, do local test and share the screenshots, etc.

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Technical design
  • Build related changes
  • Refactoring (no functional changes, no api changes)
  • Code style update (formatting, renaming) or Documentation content changes
  • Other (please describe):

Feature UI screenshots or Technical design diagrams

If this is a relatively large or complex change, kick it off by drawing the tech design with PlantUML and explaining why you chose the solution you did and what alternatives you considered, etc...
image

@zhou9584 zhou9584 changed the title Feature: scan install package Feature: scan install package Tech design Dec 18, 2023
@hydraxman
Copy link
Member

Let's make sure empty desc do not appear going forward.

@zhou9584 zhou9584 marked this pull request as ready for review December 19, 2023 02:27
@zhou9584 zhou9584 changed the title Feature: scan install package Tech design Technical design: scan install package of apps Dec 19, 2023
@zhou9584
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@zhou9584 zhou9584 merged commit b279c82 into main Dec 19, 2023
5 checks passed
@zhou9584 zhou9584 deleted the zhoule/apkScanner branch December 19, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants