Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] replace broken mmlspark notebook link in docs #4303

Merged
merged 1 commit into from
May 20, 2021

Conversation

jameslamb
Copy link
Collaborator

@jameslamb jameslamb commented May 19, 2021

The most recent link checks job failed.

URL        `https://github.com/Azure/mmlspark/blob/master/notebooks/samples/LightGBM%20-%20Quantile%20Regression%20for%20Drug%20Discovery.ipynb'
Name       `this MMLSpark example'
Parent URL file:///home/runner/work/LightGBM/LightGBM/docs/_build/html/Parallel-Learning-Guide.html, line 273, col 8
Real URL   https://github.com/Azure/mmlspark/blob/master/notebooks/samples/LightGBM%20-%20Quantile%20Regression%20for%20Drug%20Discovery.ipynb
Check time 0.464 seconds
Result     Error: 404 Not Found

reference: https://github.com/microsoft/LightGBM/runs/2618067011?check_suite_focus=true

Seems that mmlspark removed their LightGBM Quantile Regression example yesterday. See microsoft/SynapseML#1043.

This PR proposes updating the documentation to point to a different LightGBM mmlspark notebook.

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@StrikerRUS StrikerRUS merged commit c34b7ff into master May 20, 2021
@StrikerRUS StrikerRUS deleted the docs/mmlspark-link branch May 20, 2021 11:30
@StrikerRUS
Copy link
Collaborator

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants