[R-package] factor out lgb.check.r6.class() #4343
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The R package has many places where it needs to check that an object is a special LightGBM R6 class (
lgb.Booster
,lgb.Dataset
, orlgb.Predictor
). Today, it is inconsistent in the way that it does this. Some code uses special functions likelgb.is.Booster()
which call a one-line utility functionlgb.check.r6.class()
. Other code callslgb.check.r6.class()
.This code proposes factoring out
lgb.check.r6.class()
completely. I think this has the following benefits:Since what
lgb.check.r6.class()
does is so simple, I think that the added indirection it introduces is not worth it, and that the R package's code will be a bit simpler as a result of this change.