Pass train dataset parser config to valid dataset loading parser #4985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chjinche
requested review from
btrotta,
guolinke,
hzy46,
shiyu1994 and
tongwu-sh
as code owners
|
Kindly ping, much appreciated if any experts could look into the timeout ci failure? Looks unrelated to my change. |
chjinche
force-pushed
the
chjinche/fix_bug_in_val_ds_with_custom_parser
branch
from
e380580
to
aa6a1fb
Compare
|
I'm going to close and instantly re-open this PR to re-trigger Microsoft CLA bot that stuck. Sorry for the inconvenience! |
shiyu1994
approved these changes
Feb 17, 2022
40 tasks
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: We received an issue in lightgbm-transform, in which user complained that custom parser can not take effect on valid dataset.
Solution: With some investigation, we find it is a bug and could be fixed by passing train dataset parser config to valid dataset loading parser.