Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] fix conda env creation in 'regular' CI job (fixes #6282) #6283

Merged
merged 4 commits into from
Jan 22, 2024

Conversation

jameslamb
Copy link
Collaborator

@jameslamb jameslamb commented Jan 22, 2024

Fixes #6282

We install a package dask-core but then in CI later uninstall one called dask. That might not have been caught before because dask was being pulled in as a transitive dependency of something else (unsure).

Anyway, now that it isn't, conda uninstall dask fails with the error shown in the linked issue.

This resolves it by explicitly uninstalling dask-core.

@jmoralez
Copy link
Collaborator

jmoralez commented Jan 22, 2024

Some of the jobs (Linux regular) are running into mamba-org/mamba#1770, so I'm restoring the conda command. I think it's good to have the env name in case it ever tries to uninstall from base, but probably just having the dask-core will fix it.

@jameslamb jameslamb changed the title WIP: [ci] fix conda env creation in 'regular' CI job (fixes #6282) [ci] fix conda env creation in 'regular' CI job (fixes #6282) Jan 22, 2024
@jameslamb jameslamb marked this pull request as ready for review January 22, 2024 21:45
@jameslamb
Copy link
Collaborator Author

nice @jmoralez !!! I think this fixes it. Thanks so much for working through that.

And thanks for the link to that related issue from mamba.. think I recall seeing it (the problem, not that discussion thread) before, maybe during development of #6140?

Anyway, keeping it as conda uninstall is totally fine with me.

Since this is technically my PR, I think you'll need to approve for us to merge it.

@jameslamb jameslamb merged commit 2544d1b into master Jan 22, 2024
43 checks passed
@jameslamb jameslamb deleted the ci/conda-fixes branch January 22, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ci] python-package "regular" CI jobs failing to install dependencies
2 participants