release v4.3.0 #6277
Merged
release v4.3.0 #6277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gha run r-valgrind Workflow R valgrind tests has been triggered! 🚀 Status: success ✔️. |
jameslamb
changed the title
jameslamb
requested review from
guolinke,
shiyu1994,
jmoralez and
borchero
as code owners
|
Since all of the R tests (including Submitted with this note:
In the future I don't want to do that outside of the normal release process with approvals and review, but I thought it was necessary to act quickly given the short deadline from CRAN. |
|
Separately, there are some non-R CI failures blocking this PR. I think they may be blocking all PRs... I see them on the most recent I have limited time to spend on LightGBM the next few days, but can try to look into those (and document them in a separate issue) if no one else is able to get to them first. |
Happy to say the package was accepted to CRAN! The Updated
Documented in #6282. Investigating in #6283. |
docs build for this release is passing: https://readthedocs.org/projects/lightgbm/builds/23200920/ and the docs look good to me: |
The R package is passing CRAN's checks on an I'll test on my M2 laptop in a bit (just waiting on some software updates). |
|
@guolinke @jmoralez @shiyu1994 @borchero could you please take a look and let me know if you agree with releasing the current state of this branch (which is up to date with |
jmoralez
approved these changes
Jan 23, 2024
|
Built and tested the Python package on my M2 Mac (macOS Sonoma 14.3) tonight. sh build-python.sh bdist_wheel --nomp
pip install dist/lightgbm*.whl
pytest tests/python_package_testI used All tests except the Arrow ones passed. The Arrow tests all failed. logs (click me)I don't think the changeset in v4.3.0 here is the cause of either of these issues, and they seem limited to the I don't think they should delay this release, and that we can focus on fixing them (and various other macOS support issues) in the next release. |
shiyu1994
approved these changes
Jan 24, 2024
|
LGTM. Thanks! |
|
Thanks all! I'll continue with the release. |
|
Ran the following to create the git fetch upstream --tags
git tag -d stable
git push upstream :refs/tags/stable
git tag stable
git tag v4.3.0
git push upstream stable v4.3.0(NOTE: I alias this repo to https://github.com/microsoft/LightGBM/tags 
That triggered an Azure DevOps build which should create the release automatically:https://dev.azure.com/lightgbm-ci/lightgbm-ci/_build/results?buildId=15709&view=results. This takes around 90 minutes (because of the QEMU CI job). I'll do the remaining tasks tomorrow. |
|
|
|
|
This is done, and tested that the wheels installed from there work (on my intel mac). 
|
These are done. v4.3.0 now available on readthedocs.
|
done |
And with that, this release is done. Thanks everyone! |
|
For future reference... I added some code snippets to the PR description here to hopefully make it a little easier to cut the ext release. Maybe in the future if we start releasing more frequently, it'd make sense to check those into the repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release checklist:
Copied from #6191, with a few changes.
before merge
configurefile of R-package:/gha run r-configure.development.modefromunreleasedtoreleasein pkgdown config file.python-package/pyproject.tomlversionadded::annotations (docs on those)config.hhave*New in version {version}*comments addedconfig.hin this release/gha run r-valgrind(docs link)PRs that should be merged before releasing:
None
after merge
v*tag to triggerGitHubReleaseaction at Azure Pipelines.stabletag at GitHub.code to update tags (click me)
release-drafterto the automatically-created GitHub release, convert it fromDraftto published.code to publish to PyPI (summary)
(
ghis the GitHub CLI, see https://cli.github.com/manual/gh_release_download)Then confirmed that installing the latest wheel works.
pip install -i https://test.pypi.org/simple/ "lightgbm==${NEW_VERSION}" python ./examples/python-guide/logistic_regression.pyThen pushed them to real PyPI.
twine upload \ ./artifacts/*code to open that dev version PR (click me)
Notes for Reviewers
I believe this should be
v4.3.0instead ofv4.2.1because of the two breaking changes:This release is being put up so soon after
v4.2.0mainly to try to prevent CRAN from archiving the package