Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] reduce repetition of BUILD_DIRECTORY in CI scripts #6497

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

jameslamb
Copy link
Collaborator

@jameslamb jameslamb commented Jun 21, 2024

For a long time, this project's CI scripts have used mostly the following combinations:

  • lots of absolute paths to source files
  • repetitive uses of cd to reset the working directory

With the changes in #6266, I believe that these patterns are unnecessary and that builds will fail if instead these scripts use relative paths that end up pointing to files that don't exist.

In the interest of making the CI configuration easier for contributors to read and understand, this proposes:

  • removing unnecessary cd calls
  • replacing most uses of absolute paths with relative paths

@jameslamb jameslamb changed the title WIP: [ci] reduce repetition of BUILD_DIRECTORY in CI scripts [ci] reduce repetition of BUILD_DIRECTORY in CI scripts Jun 21, 2024
@jameslamb jameslamb marked this pull request as ready for review June 21, 2024 06:17
Copy link
Collaborator

@borchero borchero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jameslamb
Copy link
Collaborator Author

Thanks as always for all the reviews @borchero !

@jameslamb jameslamb merged commit bf2641d into master Jun 21, 2024
41 checks passed
@jameslamb jameslamb deleted the ci/break-up-lines branch June 21, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants