Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicates whether Roslyn is included #109

Closed
wants to merge 1 commit into from

Conversation

Forgind
Copy link
Member

@Forgind Forgind commented Dec 10, 2020

Fixes #22

I didn't see an obvious way to determine whether the C# compiler was installed for the dotnet sdk, and I didn't want to replicate all the logic from VSLocationHelper for a command prompt. Maybe right?

Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the right approach. Is it possible to expose instance itself so consumers can do arbitrary operations on it, like check for their own packages?

@Forgind
Copy link
Member Author

Forgind commented Dec 10, 2020

I could expose instance as a parameter as I have ContainsRoslynCompiler exposed here. Would you want the non-VS versions to return null for that?

@YuliiaKovalova
Copy link
Contributor

Hi @rainersigwald and @Forgind,

Do we plan to work on this PR?
Can we close it?

@rainersigwald
Copy link
Member

I think we need to have a design for #22 before taking any implementation and would favor closing this.

@Forgind
Copy link
Member Author

Forgind commented Jun 14, 2023

I think this is low enough priority that it doesn't warrant a serious design discussion. I'd personally prefer to just take this roughly as-is over closing it, but closing it makes more sense than talking about it for too long.

@Forgind Forgind closed this Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a way for consumers to validate a VS instance
3 participants