IntuneDeviceConfigurationPolicyMacOS: Fix resource deployment, fix #3539 #4099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricmestre
changed the title
NikCharlebois
approved these changes
Dec 29, 2023
This was referenced Jan 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Graph API expects property UpdateDelayPolicy to be a single string instead of a string array so the best would be to change its type like I initially did on a separate PR, nevertheless in order to not fall into a breaking change territory (even though this resource seems to be never have worked for deployments, only exports) then the fix is to simply join the array into a string separated by commas since during the export it's already doing the opposite by splitting the string into an array.
While here ensure that the resource can cope with property Id not being present (or coming from another tenant) since it's not a mandatory parameter.
This Pull Request (PR) fixes the following issues