Fix for flickering Proximity Lighting #10325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We notice a small but distracting flicker when moving from a poke to a grab pointer when pokable and grabbable objects are in close proximity. There's a single frame when there are no lights enabled. Adding a forced update to `OnEnable()` (similarly to the behaviour of `OnDisable()`) fixes the issue.
jonathoncobb
requested review from
david-c-kline and
keveleigh
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
keveleigh
approved these changes
Nov 16, 2021
|
thanks for the fix @jonathoncobb |
keveleigh
added a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 7, 2021
…ximity-light-flicker Fix for flickering Proximity Lighting
keveleigh
added a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 7, 2021
…ximity-light-flicker Fix for flickering Proximity Lighting
keveleigh
added a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 7, 2021
…ximity-light-flicker Fix for flickering Proximity Lighting
keveleigh
added a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 7, 2021
…ximity-light-flicker Fix for flickering Proximity Lighting
keveleigh
added a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 7, 2021
…ximity-light-flicker Fix for flickering Proximity Lighting
keveleigh
added a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 8, 2021
…ximity-light-flicker Fix for flickering Proximity Lighting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We notice a small but distracting flicker when moving from a poke to a grab pointer when pokable and grabbable objects are in close proximity. There's a single frame when there are no lights enabled.
Changes
Adding a forced update to
OnEnable()(similarly to the behaviour ofOnDisable()) fixes the issue.