Reduce per frame allocations in hand mesh. #9756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-c-kline
requested review from
CDiaz-MS,
cre8ivepark,
julenka and
MaxWang-MS
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
MaxWang-MS
approved these changes
May 5, 2021
keveleigh
reviewed
May 5, 2021
.../MRTK/Providers/WindowsMixedReality/XR2018/Controllers/WindowsMixedRealityArticulatedHand.cs
Outdated
Show resolved
Hide resolved
The Unity version change is something we try to do periodically and it was included here as an opportunity to not have a complete PR for just that change. I am happy to revert that part if folks wish me to. 😄 |
…tions is 1.4ish ms faster with a serial for)
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
keveleigh
reviewed
May 5, 2021
Assets/MRTK/Providers/OpenXR/Scripts/MicrosoftArticulatedHand.cs
Outdated
Show resolved
Hide resolved
Assets/MRTK/Providers/WindowsMixedReality/Shared/WindowsMixedRealityHandMeshProvider.cs
Show resolved
Hide resolved
Assets/MRTK/Providers/WindowsMixedReality/Shared/WindowsMixedRealityHandMeshProvider.cs
Outdated
Show resolved
Hide resolved
…ealityHandMeshProvider.cs Co-authored-by: Kurtis <kurtie@microsoft.com>
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
keveleigh
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reduces some per-frame allocations and increases the Unity version in projectversion.txt to 2018.4.34.
Please merge #9746 before this one, as this contains changes from that PR.