Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs and changes needed for local dev and test #14

Merged
merged 4 commits into from
Feb 19, 2021
Merged

Conversation

sinedied
Copy link
Contributor

@sinedied sinedied commented Feb 5, 2021

Note: hardcoded URL in frontend app was removed. It should not affect the prod environment with the <base href> added, but if it fails I can take a look why 😉 @cmaneu

@sinedied sinedied mentioned this pull request Feb 5, 2021
Copy link
Contributor

@jdubois jdubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For tracking links we need to discuss, I'll add this in the Teams channel so everybody can see it

@sinedied
Copy link
Contributor Author

sinedied commented Feb 5, 2021

Feel free to edit if needed. We can always add tracking after at once.

EDIT: I removed them

@jdubois
Copy link
Contributor

jdubois commented Feb 19, 2021

Thanks @sinedied !

@jdubois jdubois merged commit da3ba51 into main Feb 19, 2021
@jdubois jdubois deleted the local-dev branch March 23, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants