-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use loading pattern #1553
Use loading pattern #1553
Conversation
…PI format providers
src/Microsoft.OpenApi/Reader/Services/OpenApiWorkspaceLoader.cs
Dismissed
Show dismissed
Hide dismissed
src/Microsoft.OpenApi/Reader/Services/OpenApiRemoteReferenceCollector.cs
Fixed
Show fixed
Hide fixed
src/Microsoft.OpenApi/Reader/Services/OpenApiRemoteReferenceCollector.cs
Fixed
Show fixed
Hide fixed
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
…he API surface; cleanup tests
…tionality that isn't reader-specific to the factory
… to reuse the ReadAsync() methods
…rd for JsonSchema.NET to qualify it as a valid keyword
…n, else default to the input file extension
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR looks good. I want have a conversation about having a Load method that doesn't require you to say what the format is, but we can defer that to conversation to after this PR has been merged..
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
This PR is an implementation of the loading design proposed as part of this conversation: #1446 (comment) which seeks to resolve the issue highlighted in #1434
It involves:
Fixes #1434
Fixes #1447