Refactor interface to compiler, support SPIR-V IL programs #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenatali
force-pushed
the
compiler-refactor
branch
from
e3f9849
to
6287ce2
Compare
|
History cleaned up. Since the v2 compiler interface isn't merged upstream yet, there's possibly going to be more changes to it, but it's isolated enough that I think that'll be fine. One TBD is that if I flip the switch to claim CL 3.0, this change as it currently exists will be out-of-spec since it doesn't support specialization constants. Further, the v1 compiler will always be out-of-spec if it claims CL 3.0 support. Maybe this is okay, or maybe using the v1 compiler needs to not report SPIR-V support, or maybe the v1 compiler needs to not claim CL 3.0 support. Filed KhronosGroup/OpenCL-Docs#602 to get more clarity on that. Either way, since CL 3.0 isn't flipped on by default yet, I think this is fine as-is. |
shawnhar
approved these changes
Apr 22, 2021
vdwtanner
reviewed
Apr 22, 2021
jenatali
force-pushed
the
compiler-refactor
branch
from
e36eef0
to
d026f0d
Compare
…cialization constants
jenatali
force-pushed
the
compiler-refactor
branch
from
d026f0d
to
6db8c3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first (large) commit here abstracts the compiler interface, so that the external dependency on
clc_compiler.handclglon12compiler.dllis behind a pure-virtual interface, which allows us to have multiple drop-in implementations.After that, a second compiler backend is dropped in, which uses a completely reworked
clc_compiler.hand targetsclon12compiler.dll. This corresponds to a Mesa merge request: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10322.Then, support for SPIR-V IL programs is added. Lastly, a test is added - currently with bugfixes, I'd like to go back and clean up the commit history here.