Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up viztracer version and pull binaries from storage account for … #1661

Merged
merged 3 commits into from
Nov 11, 2022

Conversation

snehapar9
Copy link
Contributor

@snehapar9 snehapar9 commented Nov 4, 2022

…python 3.11

  • The purpose of this PR is explained in this message or in an issue.
  • [ ] Tests are included and/or updated for code changes.
  • [ ] Proper license headers are included in each file.

The purpose of this PR is to install python 3.11 tools to /opt/python/3/bin instead of usr/local/bin folder as requested by Antares.

However, looks like vizplugins is not supported in python 3.11 and this package could not be transitioned.
https://pypi.org/project/vizplugins/

Edit: pip install vizplugins fails for python 3.11 because of building wheel for psutil failure.
image

Here is a screenshot to validate this change.

image

@snehapar9 snehapar9 requested a review from a team as a code owner November 4, 2022 22:27
images/runtime/python/template.Dockerfile Outdated Show resolved Hide resolved
images/runtime/python/template.Dockerfile Outdated Show resolved Hide resolved
images/runtime/python/cgmanifest.json Show resolved Hide resolved
@gaogaotiantian
Copy link

viztracer dev here - VizPlugin is a pure Python implementation so it should support 3.11. The reason that 3.11 is not shown on the github page is the label is never updated. However, I'll test if it actually works on 3.11 and update the version.

The attach mechanism is updated between 0.14.3 and the current 0.15.5, which I believe was used? VizTracer now supports gdb based attach by default, which means you don't need a pre-installed process to be attached. However, you can still use the backward-compatible command with viztracer --attach_installed to keep the old behavior where SIGUSR1 and SIGUSR2 are used as the trigger signals.

LMK if there's anything I can help with this.

@snehapar9
Copy link
Contributor Author

snehapar9 commented Nov 6, 2022

viztracer dev here - VizPlugin is a pure Python implementation so it should support 3.11. The reason that 3.11 is not shown on the github page is the label is never updated. However, I'll test if it actually works on 3.11 and update the version.

The attach mechanism is updated between 0.14.3 and the current 0.15.5, which I believe was used? VizTracer now supports gdb based attach by default, which means you don't need a pre-installed process to be attached. However, you can still use the backward-compatible command with viztracer --attach_installed to keep the old behavior where SIGUSR1 and SIGUSR2 are used as the trigger signals.

LMK if there's anything I can help with this.

Building wheel for psutil fails while installing vizplugins 0.1.2 for python 3.11 in Windows.

@gaogaotiantian
Copy link

Building wheel for psutil fails while installing vizplugins 0.1.2 for python 3.11 in Windows.

This seems like a psutil issue - giampaolo/psutil#2165. The feature for VizPlugins requires psutil to record CPU/memory usage. If that's a necessary feature here, then we both need to wait for psutil to figure this out.

@gaogaotiantian
Copy link

Just FYI, there are some fundamental issues with 0.15.5 and the plugins, besides the fact that psutil does not support 3.11 now. I'm planning to check in the fix and bump the version to 0.15.6 as soon as psutil adds the support.

@snehapar9
Copy link
Contributor Author

Just FYI, there are some fundamental issues with 0.15.5 and the plugins, besides the fact that psutil does not support 3.11 now. I'm planning to check in the fix and bump the version to 0.15.6 as soon as psutil adds the support.

Thanks for the update!

Copy link
Contributor

@cormacpayne cormacpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@snehapar9 snehapar9 merged commit ecf8edb into main Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants