Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the pack failure due to - The icon file 'icon.png' does not exist in the package - error #1672

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix the pack failure due to - The icon file 'icon.png' does not exist in the package - error #1672

wants to merge 2 commits into from

Conversation

ckkashyap
Copy link
Contributor

@ckkashyap ckkashyap commented Jul 18, 2023 •
edited
Loading

@ckkashyap ckkashyap requested a review from a team as a code owner July 18, 2023 19:30
@ckkashyap ckkashyap mentioned this pull request Jul 19, 2023
Open
lesaltzm
lesaltzm requested changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@lesaltzm lesaltzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use src/buildLocalPackages.cmd to generate packages locally.
That script, as well as our build pipeline adds these properties.

Is there another reason we'd need this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesaltzm lesaltzm lesaltzm requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ckkashyap @lesaltzm @ckkMicrosoft