Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #378 #379

Merged
merged 3 commits into from
May 9, 2022
Merged

Fix #378 #379

merged 3 commits into from
May 9, 2022

Conversation

MikeStall
Copy link
Contributor

If(true, OptionSet.Option1)

OptionSetValue should derive from ValidFormulaValue, not FormulaValue

Fix #378
d1baf3d 
If(true, OptionSet.Option1)

OptionSetValue should derive from ValidFormulaValue, not FormulaValue
@coveralls
Copy link

coveralls commented May 7, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 303682

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 28 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 57.768%
Files with Coverage Reduction New Missed Lines %
/src/libraries/Microsoft.PowerFx.Interpreter/EvalVisitor.cs 28 86.23%
Totals Coverage Status
Change from base Build 303680: -0.005%
Covered Lines: 19641
Relevant Lines: 34000
💛 - Coveralls

@LucGenetier LucGenetier merged commit 28050c0 into main May 9, 2022
@lesaltzm lesaltzm deleted the jmstall/if378 branch July 18, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucGenetier LucGenetier LucGenetier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MikeStall @coveralls @LucGenetier