Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stig update #77

Merged
merged 24 commits into from
Aug 16, 2018
Merged

Stig update #77

merged 24 commits into from
Aug 16, 2018

Conversation

winthrop28
Copy link
Contributor

@winthrop28 winthrop28 commented Aug 15, 2018

Pull Request (PR) description:
Thanks for submitting a Pull Request (PR), your contribution is greatly appreciated!
Updates to the Stigs in the issues listed below. Updated the XMLAttribute data file to PascalCase so the proper parameters are used when converted to XML. Updated service name from McAfee to masvc for rule V-15505.

This Pull Request (PR) fixes the following issues:
This Pull Request fixes the following issues: #74 #75 #76

Task list:

  • Change details added to Unreleased section of README.md (Not required for Convert modules)?
  • Added/updated documentation, comment-based help and descriptions where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

@LLansey LLansey changed the title Stig update#11479 Stig update Aug 15, 2018
Copy link
Member

@jcwalker jcwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 12 files at r3, 1 of 4 files at r4, 20 of 22 files at r5, 1 of 1 files at r7.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @winthrop28, @athaynes, @regedit32, and @chasewilson)


README.md, line 92 at r7 (raw file):

Quoted 10 lines of code…
Update IIS Server STIG V-76723.a with correct value
 
Added the following STIGs:
 
* Windows Server 2012R2 MS STIG V2R13
* Windows Server 2012R2 DC STIG V2R13
* Windows 2012 DNS V1R10
* Windows Domain V2R10
* Windows Forest V2R8
* IE11-V1R16

This should go in the unreleased section

@nehrua nehrua self-assigned this Aug 15, 2018
Copy link
Member

@chasewilson chasewilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @winthrop28, @athaynes, @regedit32, @chasewilson, and @nehrua)

Copy link
Member

@chasewilson chasewilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @winthrop28, @athaynes, @regedit32, @chasewilson, and @nehrua)

Copy link
Contributor

@athaynes athaynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 25 of 26 files reviewed, 2 unresolved discussions (waiting on @jcwalker, @winthrop28, @regedit32, @chasewilson, and @nehrua)


README.md, line 79 at r8 (raw file):

* [@nehrua](https://github.com/nehrua) (Nehru Ali)
* [@regedit32](https://github.com/regedit32) (Reggie Gibson)
* [@llansey] (https://github.com/llansey) (La'Neice Lansey)

This will get automatically added when use our dev merge utility for future reference.

Copy link
Member

@jcwalker jcwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r8.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @winthrop28, @regedit32, @chasewilson, and @nehrua)

@jcwalker jcwalker closed this Aug 16, 2018
@jcwalker jcwalker reopened this Aug 16, 2018
@jcwalker jcwalker merged commit 11bbce3 into dev Aug 16, 2018
@LLansey LLansey deleted the StigUpdate#11479 branch August 16, 2018 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants