Feature/lab color representation #12935

RubenFricke · 2021-08-27T18:52:23Z

Summary of the Pull Request

Added CIE LAB and CIE XYZ color space to the Color Picker.

What is include in the PR:

This pull request adds the CIE LAB color space, also referred to as L* a* b* and the CIE XYZ color space to the Color Picker. To calculate the CIELAB space from RGB, a conversion from RGB to CIEXYZ had to be made, this conversion is also included in this pull request.

How does someone test / validate:

Open Color Picker, and validate that the CIE LAB and CIE XYZ color space are visible, if these color spaces are enabled via the settings.

Validate that the output of the color is correct (use online available color conversion websites if you don't have any tool available)

Quality Checklist

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA. ✅

…o XYZ)

… issues

github-actions · 2021-08-27T18:55:16Z

@check-spelling-bot Report

Unrecognized words, please review:

chromaticities
cielab
CIEXYZ
companding
debian
mindaro

Previously acknowledged words that are now absent

Accessible coc djsoref dogancelik estdir Fody ftps gmx htt inprivate itsme mfreadwrite mfuuid Nefario nitroin null nunit Radiobuttons sidepanel ulazy XSmall xunit

Some files were were automatically ignored

These sample patterns would exclude them:

^src/modules/previewpane/UnitTests-MarkdownPreviewHandler/HelperFiles/MarkdownWithHTMLImageTag\.txt$

You should consider adding them to:

.github/actions/spell-check/excludes.txt

File matching is via Perl regular expressions.

To check these files, more of their words need to be in the dictionary than not. You can use patterns.txt to exclude portions, add items to the dictionary (e.g. by adding them to allow.txt), or fix typos.

To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the git@github.com:RubenFricke/PowerToys.git repository
on the feature/lab-color-representation branch:

update_files() {
perl -e '
my @expect_files=qw('".github/actions/spell-check/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spell-check/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
(cat '.github/actions/spell-check/excludes.txt' - <<EOF
$should_exclude_patterns
EOF
) |grep .|
sort -f |
uniq > '.github/actions/spell-check/excludes.txt.temp' &&
mv '.github/actions/spell-check/excludes.txt.temp' '.github/actions/spell-check/excludes.txt'
}

comment_json=$(mktemp)
curl -L -s -S \
  --header "Content-Type: application/json" \
  "https://api.github.com/repos/microsoft/PowerToys/issues/comments/907407158" > "$comment_json"
comment_body=$(mktemp)
jq -r .body < "$comment_json" > $comment_body
rm $comment_json

patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")
  

patch_add=$(perl -e '$/=undef;
$_=<>;
s{<details>.*}{}s;
s{^#.*}{};
s{\n##.*}{};
s{(?:^|\n)\s*\*}{}g;
s{\s+}{ }g;
print' < "$comment_body")
  

should_exclude_patterns=$(perl -e '$/=undef;
$_=<>;
exit unless s{(?:You should consider excluding directory paths|You should consider adding them to).*}{}s;
s{.*These sample patterns would exclude them:}{}s;
s{.*\`\`\`([^`]*)\`\`\`.*}{$1}m;
print' < "$comment_body" | grep . || true)

update_files
rm $comment_body
git add -u

If you see a bunch of garbage

If it relates to a ...

well-formed pattern

See if there's a pattern that would match it.

If not, try writing one and adding it to the patterns.txt file.

Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

Note that patterns can't match multiline strings.

binary-ish string

Please add a file path to the excludes.txt file instead of just accepting the garbage.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

src/modules/colorPicker/ColorPickerUI/Helpers/ColorHelper.cs

RubenFricke · 2021-08-28T16:47:49Z

@martinchrzan , As I stated above in the pull request description To calculate L* a* b*, CIEXYZ must also be calculated. This is also a color space that already gets calculated right now. Is there also a need to add the XYZ color format to the color picker for the user? If so, can I add it to this issue/pr? Or does this require a new issue/pr?

Do you happen to know the answer to this? Or someone who can answer this? Thanks again!

martinchrzan · 2021-08-28T16:48:18Z

Yeah, I think adding these links to summary would be helpful.

…

On Sat, 28 Aug 2021, 18:46 Ruben Fricke, ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/modules/colorPicker/ColorPickerUI/Helpers/ColorHelper.cs <#12935 (comment)>: > + double b = color.B / 255d; + + // inverse companding, gamma correction must be undone + double rLinear = (r > 0.04045) ? Math.Pow((r + 0.055) / 1.055, 2.4) : (r / 12.92); + double gLinear = (g > 0.04045) ? Math.Pow((g + 0.055) / 1.055, 2.4) : (g / 12.92); + double bLinear = (b > 0.04045) ? Math.Pow((b + 0.055) / 1.055, 2.4) : (b / 12.92); + + return ( + (rLinear * 0.4124) + (gLinear * 0.3576) + (bLinear * 0.1805), + (rLinear * 0.2126) + (gLinear * 0.7152) + (bLinear * 0.0722), + (rLinear * 0.0193) + (gLinear * 0.1192) + (bLinear * 0.9505) + ); + } + + /// <summary> + /// Convert a CIE XYZ color <see cref="double"/> to a CIE LAB color (LAB) Thanks a lot for your feedback, I really appreciate it 😄! For converting from sRGB to XYZ, I used, among others, this page: https://en.wikipedia.org/wiki/SRGB#The_reverse_transformation_(sRGB_to_CIE_XYZ) For converting from XYZ to L*a*b*, I used, among others, this page: https://en.wikipedia.org/wiki/CIELAB_color_space#Converting_between_CIELAB_and_CIEXYZ_coordinates . Should I refer these pages in the code as well (in the summary)? — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#12935 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC3JYIWFYNQV6BI3XRRW5KLT7EHGRANCNFSM5C6DCPPQ> .

martinchrzan · 2021-08-28T16:50:29Z

@RubenFricke I would guess that you can include that color format in this PR as well since you have already added a code to calculate it, but I would create a new issue and refer to it from this PR, so we can keep a track of it.

github-actions · 2021-08-28T17:14:03Z

@check-spelling-bot Report

Unrecognized words, please review:

SRGB

Previously acknowledged words that are now absent

Accessible coc djsoref dogancelik estdir Fody ftps gmx htt inprivate itsme mfreadwrite mfuuid Nefario nitroin null nunit Radiobuttons sidepanel ulazy XSmall xunit

Some files were were automatically ignored

These sample patterns would exclude them:

^src/modules/previewpane/UnitTests-MarkdownPreviewHandler/HelperFiles/MarkdownWithHTMLImageTag\.txt$

You should consider adding them to:

.github/actions/spell-check/excludes.txt

File matching is via Perl regular expressions.

To check these files, more of their words need to be in the dictionary than not. You can use patterns.txt to exclude portions, add items to the dictionary (e.g. by adding them to allow.txt), or fix typos.

To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the git@github.com:RubenFricke/PowerToys.git repository
on the feature/lab-color-representation branch:

update_files() {
perl -e '
my @expect_files=qw('".github/actions/spell-check/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spell-check/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
(cat '.github/actions/spell-check/excludes.txt' - <<EOF
$should_exclude_patterns
EOF
) |grep .|
sort -f |
uniq > '.github/actions/spell-check/excludes.txt.temp' &&
mv '.github/actions/spell-check/excludes.txt.temp' '.github/actions/spell-check/excludes.txt'
}

comment_json=$(mktemp)
curl -L -s -S \
  --header "Content-Type: application/json" \
  "https://api.github.com/repos/microsoft/PowerToys/issues/comments/907656539" > "$comment_json"
comment_body=$(mktemp)
jq -r .body < "$comment_json" > $comment_body
rm $comment_json

patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")
  

patch_add=$(perl -e '$/=undef;
$_=<>;
s{<details>.*}{}s;
s{^#.*}{};
s{\n##.*}{};
s{(?:^|\n)\s*\*}{}g;
s{\s+}{ }g;
print' < "$comment_body")
  

should_exclude_patterns=$(perl -e '$/=undef;
$_=<>;
exit unless s{(?:You should consider excluding directory paths|You should consider adding them to).*}{}s;
s{.*These sample patterns would exclude them:}{}s;
s{.*\`\`\`([^`]*)\`\`\`.*}{$1}m;
print' < "$comment_body" | grep . || true)

update_files
rm $comment_body
git add -u

If you see a bunch of garbage

If it relates to a ...

well-formed pattern

See if there's a pattern that would match it.

If not, try writing one and adding it to the patterns.txt file.

Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

Note that patterns can't match multiline strings.

binary-ish string

Please add a file path to the excludes.txt file instead of just accepting the garbage.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

github-actions · 2021-08-28T17:35:57Z

@check-spelling-bot Report

Unrecognized words, please review:

SRGB

Previously acknowledged words that are now absent

Accessible CIEXYZ coc djsoref dogancelik estdir Fody ftps gmx htt inprivate itsme mfreadwrite mfuuid Nefario nitroin null nunit Radiobuttons sidepanel ulazy XSmall xunit

Some files were were automatically ignored

These sample patterns would exclude them:

^src/modules/previewpane/UnitTests-MarkdownPreviewHandler/HelperFiles/MarkdownWithHTMLImageTag\.txt$

You should consider adding them to:

.github/actions/spell-check/excludes.txt

File matching is via Perl regular expressions.

To check these files, more of their words need to be in the dictionary than not. You can use patterns.txt to exclude portions, add items to the dictionary (e.g. by adding them to allow.txt), or fix typos.

To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands

... in a clone of the git@github.com:RubenFricke/PowerToys.git repository
on the feature/lab-color-representation branch:

update_files() {
perl -e '
my @expect_files=qw('".github/actions/spell-check/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"$patch_remove"');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spell-check/expect.txt";
use File::Path qw(make_path);
use File::Basename qw(dirname);
make_path (dirname($new_expect_file));
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"$patch_add"');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a)."-".$a cmp lc($b)."-".$b} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;
system("git", "add", $new_expect_file);
'
(cat '.github/actions/spell-check/excludes.txt' - <<EOF
$should_exclude_patterns
EOF
) |grep .|
sort -f |
uniq > '.github/actions/spell-check/excludes.txt.temp' &&
mv '.github/actions/spell-check/excludes.txt.temp' '.github/actions/spell-check/excludes.txt'
}

comment_json=$(mktemp)
curl -L -s -S \
  --header "Content-Type: application/json" \
  "https://api.github.com/repos/microsoft/PowerToys/issues/comments/907660132" > "$comment_json"
comment_body=$(mktemp)
jq -r .body < "$comment_json" > $comment_body
rm $comment_json

patch_remove=$(perl -ne 'next unless s{^</summary>(.*)</details>$}{$1}; print' < "$comment_body")
  

patch_add=$(perl -e '$/=undef;
$_=<>;
s{<details>.*}{}s;
s{^#.*}{};
s{\n##.*}{};
s{(?:^|\n)\s*\*}{}g;
s{\s+}{ }g;
print' < "$comment_body")
  

should_exclude_patterns=$(perl -e '$/=undef;
$_=<>;
exit unless s{(?:You should consider excluding directory paths|You should consider adding them to).*}{}s;
s{.*These sample patterns would exclude them:}{}s;
s{.*\`\`\`([^`]*)\`\`\`.*}{$1}m;
print' < "$comment_body" | grep . || true)

update_files
rm $comment_body
git add -u

If you see a bunch of garbage

If it relates to a ...

well-formed pattern

See if there's a pattern that would match it.

If not, try writing one and adding it to the patterns.txt file.

Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

Note that patterns can't match multiline strings.

binary-ish string

Please add a file path to the excludes.txt file instead of just accepting the garbage.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

…mments

src/modules/colorPicker/ColorPickerUI/Helpers/ColorHelper.cs

src/modules/colorPicker/ColorPickerUI/Helpers/ColorRepresentationHelper.cs

mykhailopylyp · 2021-08-30T15:15:12Z

It looks like we have rounding/precision issues here

RubenFricke · 2021-08-30T15:21:15Z

Thanks for all your feedback @mykhailopylyp . I will look into it!

crutkas · 2021-09-20T16:39:22Z

@RubenFricke / @mykhailopylyp what needs to happen so we can roll this improvement into the 0.47 release at the end of the month.

jaimecbernardo · 2021-09-20T17:03:22Z

@crutkas , from the feedback, looks like the calculations are still not quite right for the color format.

crutkas · 2021-09-20T17:19:47Z

@jaimecbernardo is this something we can just do a quick fix for?

RubenFricke · 2021-09-20T18:00:22Z

I will fix the calculations, sorry! Only question, what format do you want to output?

jaimecbernardo · 2021-09-20T18:09:54Z

@RubenFricke ,

I'm not sure which is the standard here.
You are one of the original proposals for these formats. @Ayanari3 as well.
@TheDecryptor also suggested the CSS 4 format.

Which would be useful to you?
I suppose more lines can be added if needed later.

Changed L*a*b*(L,a,b) to CIELab(L,a,b)

htcfreek · 2021-09-21T16:32:52Z

@RubenFricke
There seems to be a round bug. Pipeline is failing because of test results.

crutkas · 2021-09-23T21:27:36Z

@jaimecbernardo / @dedavis6797 do we have time for this to be in .47?

jaimecbernardo

This looks good to me.
Thank you for the contribution.
I do have some questions regarding presentation of the values.
Looking for those in other sites show these values presented with some decimal places. Why are we not showing these as well?

src/modules/colorPicker/ColorPickerUI/Helpers/ColorRepresentationHelper.cs

jaimecbernardo · 2021-09-24T10:35:08Z

@jaimecbernardo / @dedavis6797 do we have time for this to be in .47?

Reviewing. Let's try to get this in, then.

jaimecbernardo · 2021-09-24T11:23:17Z

@RubenFricke ,
In case you didn't add the decimal places because they didn't fit, I have another PR that can go in after yours to increase the size of the window:
#13420

jaimecbernardo

I've added the decimal places and committed the changes.
Thank you for the contribution!

RubenFricke added 7 commits August 27, 2021 19:23

Created logic to convrt RGB to CIELAB (with intermediate step to CIEXYZ)

73501a9

Added CIELAB to the available color representation types

2bd8076

Created tests for the color conversion from RGB to LAB (and for RGB t…

59813e0

…o XYZ)

Update ColorPickerViewModel to keep the L*a*b* format the same

4832f20

Improved variable names & comment

c3a04cb

Remove url from color converting website to avoid unnecessary license…

5981a0b

… issues

Removed typo of the wrong variable

a985c93

niels9001 requested review from martinchrzan and martinchrzan-msft August 28, 2021 06:10

martinchrzan reviewed Aug 28, 2021

View reviewed changes

src/modules/colorPicker/ColorPickerUI/Helpers/ColorHelper.cs Show resolved Hide resolved

martinchrzan approved these changes Aug 28, 2021

View reviewed changes

martinchrzan removed the request for review from martinchrzan-msft August 28, 2021 13:39

Added expected words into dictionary

4f9a783

Added links to explain used formulas

8279f27

Added CIE XYZ color space

fd74189

Added 'SRGB' to the dictionary

af8205b

RubenFricke mentioned this pull request Aug 28, 2021

Add CIE XYZ color space to the Color Picker #12937

Closed

Updated the range for the X and Z value in the CIE XYZ color space co…

81e4385

…mments

jaimecbernardo requested a review from mykhailopylyp August 30, 2021 10:35

mykhailopylyp reviewed Aug 30, 2021

View reviewed changes

src/modules/colorPicker/ColorPickerUI/Helpers/ColorHelper.cs Outdated Show resolved Hide resolved

mykhailopylyp reviewed Aug 30, 2021

View reviewed changes

src/modules/colorPicker/ColorPickerUI/Helpers/ColorHelper.cs Outdated Show resolved Hide resolved

mykhailopylyp reviewed Aug 30, 2021

View reviewed changes

src/modules/colorPicker/ColorPickerUI/Helpers/ColorRepresentationHelper.cs Show resolved Hide resolved

Fixed XYZ to LAB calculations

1d9fff0

RubenFricke added 2 commits September 20, 2021 20:17

Changed output format for CIELAb

2b6047d

Changed L*a*b*(L,a,b) to CIELab(L,a,b)

Changed output in tests

c3c7c3c

jaimecbernardo self-requested a review September 21, 2021 23:26

RubenFricke added 2 commits September 23, 2021 21:13

Fixed tests

3d0ebc5

Added extra accuracy

ec3dc7c

jaimecbernardo reviewed Sep 24, 2021

View reviewed changes

src/modules/colorPicker/ColorPickerUI/Helpers/ColorRepresentationHelper.cs Outdated Show resolved Hide resolved

src/modules/colorPicker/ColorPickerUI/Helpers/ColorRepresentationHelper.cs Outdated Show resolved Hide resolved

jaimecbernardo mentioned this pull request Sep 24, 2021

[Color Picker] Increase width of editor window #13420

Merged

10 tasks

Add decimal places to cielab and ciexyz formats

ec8aca5

jaimecbernardo approved these changes Sep 24, 2021

View reviewed changes

jaimecbernardo merged commit 3358fd9 into microsoft:master Sep 24, 2021

jaimecbernardo mentioned this pull request Mar 16, 2022

Increase precision of CIEXYZ conversion matrix #17041

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/lab color representation #12935

Feature/lab color representation #12935

RubenFricke commented Aug 27, 2021 •

edited

Loading

github-actions bot commented Aug 27, 2021 •

edited

Loading

RubenFricke commented Aug 28, 2021

martinchrzan commented Aug 28, 2021 via email

martinchrzan commented Aug 28, 2021

github-actions bot commented Aug 28, 2021 •

edited

Loading

github-actions bot commented Aug 28, 2021 •

edited

Loading

mykhailopylyp commented Aug 30, 2021

RubenFricke commented Aug 30, 2021

crutkas commented Sep 20, 2021

jaimecbernardo commented Sep 20, 2021

crutkas commented Sep 20, 2021

RubenFricke commented Sep 20, 2021

jaimecbernardo commented Sep 20, 2021

htcfreek commented Sep 21, 2021

crutkas commented Sep 23, 2021

jaimecbernardo left a comment

jaimecbernardo commented Sep 24, 2021

jaimecbernardo commented Sep 24, 2021

jaimecbernardo left a comment

Feature/lab color representation #12935

Feature/lab color representation #12935

Conversation

RubenFricke commented Aug 27, 2021 • edited Loading

Summary of the Pull Request

Quality Checklist

Contributor License Agreement (CLA)

github-actions bot commented Aug 27, 2021 • edited Loading

@check-spelling-bot Report

Unrecognized words, please review:

RubenFricke commented Aug 28, 2021

martinchrzan commented Aug 28, 2021 via email

martinchrzan commented Aug 28, 2021

github-actions bot commented Aug 28, 2021 • edited Loading

@check-spelling-bot Report

Unrecognized words, please review:

github-actions bot commented Aug 28, 2021 • edited Loading

@check-spelling-bot Report

Unrecognized words, please review:

mykhailopylyp commented Aug 30, 2021

RubenFricke commented Aug 30, 2021

crutkas commented Sep 20, 2021

jaimecbernardo commented Sep 20, 2021

crutkas commented Sep 20, 2021

RubenFricke commented Sep 20, 2021

jaimecbernardo commented Sep 20, 2021

htcfreek commented Sep 21, 2021

crutkas commented Sep 23, 2021

jaimecbernardo left a comment

Choose a reason for hiding this comment

jaimecbernardo commented Sep 24, 2021

jaimecbernardo commented Sep 24, 2021

jaimecbernardo left a comment

Choose a reason for hiding this comment

RubenFricke commented Aug 27, 2021 •

edited

Loading

github-actions bot commented Aug 27, 2021 •

edited

Loading

github-actions bot commented Aug 28, 2021 •

edited

Loading

github-actions bot commented Aug 28, 2021 •

edited

Loading