Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Shortcuts Guide and PowerRename settings pages #1574

Closed
wants to merge 6 commits into from
Closed

Added Shortcuts Guide and PowerRename settings pages #1574

wants to merge 6 commits into from

Conversation

niels9001
Copy link
Contributor

Summary of the Pull Request

  • Added Shortcuts Guide and PowerRename settings pages
  • Stylized textstyles and margins
  • Added VisualState logic for sidepanel containing e.g. learn more buttons and contributors list

References

PR Checklist

  • [] Applies to #xxx
  • [] CLA signed. If not, go over here and sign the CLA
  • [] Tests added/passed
  • [] Requires documentation to be updated
  • [] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@niels9001
Added a General tab page with XAML layout and controls according to spec
f480dff
@niels9001
- Added Shortcuts Guide and PowerRename settings pages
066ace6 
- Stylized textstyles and margins
- Added VisualState logic for sidepanel containing e.g. learn more buttons and contributors list
@niels9001 niels9001 changed the title Dev/settings v2 Added Shortcuts Guide and PowerRename settings pages Mar 13, 2020
@niels9001 niels9001 mentioned this pull request Mar 13, 2020
Closed
ghost
ghost suggested changes Mar 14, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR Niels, please change the target branch from master to microsoft:dev/settingsV2.

Thanks.

@crutkas
Copy link
Member

crutkas commented Mar 14, 2020

Good catch!

@crutkas crutkas changed the base branch from master to dev/settingsV2 March 14, 2020 02:14
@crutkas
Copy link
Member

crutkas commented Mar 14, 2020

Ok. I went in and tweaked the branch

@niels9001 niels9001 closed this Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niels9001 @crutkas