Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PTRun]Remove Wox plugin install dead code/deps #15869

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

jaimecbernardo
Copy link
Collaborator

Summary of the Pull Request

What is this about:

We don't use Wox infrastructure to install plugins, which means we're including some dependencies we don't need in the installer.

What is included in the PR:
Remove dead code/dependencies.

How does someone test / validate:
Project builds and PowerToys Run still functions properly.

Copy link
Member

@crutkas crutkas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending build completion

@crutkas crutkas added the Hot Fix Items we will product an out-of-band release for label Feb 1, 2022
Copy link
Contributor

@yuyoyuppe yuyoyuppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaning up is always nice!

@jaimecbernardo jaimecbernardo merged commit 55e3a94 into main Feb 2, 2022
@yuyoyuppe yuyoyuppe deleted the dev/jaimecbernardo/removeSharpZipLib branch February 2, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hot Fix Items we will product an out-of-band release for
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants