-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to Shortcuts Guide, PowerRename settings pages. Contributors sidepanel added #1694
Conversation
- Stylized textstyles and margins - Added VisualState logic for sidepanel containing e.g. learn more buttons and contributors list
@niels9001 looks like we kept moving and now we have a decent conflict here before we can merge in |
@clintrutkas Sorry about that. What is the latest branch for the settings v2? I can get on that one and manually add the stuff of this PR back in? |
Hi @niels9001 thanks for sending your PR in. when you start a new task:
When create a branch, follow this convension:
example: when you create a PR, set target branch to: This will help you avoid working from a branch that is behind. The UI looks great!!! |
are you able to fill out the PR checklist? Please let me or Clint know. [] Applies to #xxx thanks. |
he is CLA signed (and member of the org) |
@crutkas @laviusmotileng-ms What do you recommend? I'm happy to close this PR, get on the latest branch and add all of the stuff back in, and create a new PR? |
Yes. |
I think this is the easier route. |
pretty sure #1735 did this |
Summary of the Pull Request
References
#889 #1484 #1482 #1579
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed