Setting v2: added power preview settings #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
yuyoyuppe
approved these changes
Mar 26, 2020
yuyoyuppe
reviewed
Mar 26, 2020
|
@laviusmotileng-ms
Call stack (doesn't help much) KernelBase.dll!00007ffaec63faff() Unknown
combase.dll!00007ffaee60845b() Unknown
Windows.UI.Xaml.dll!00007ffacaac2ec0() Unknown
Windows.UI.Xaml.dll!00007ffacaac30b9() Unknown
Windows.UI.Xaml.dll!00007ffaca7c9c3f() Unknown
Windows.UI.Xaml.dll!00007ffaca5326ad() Unknown
Windows.UI.Xaml.dll!00007ffaca62990a() Unknown
Windows.UI.Xaml.dll!00007ffaca494238() Unknown
Windows.UI.Xaml.dll!00007ffaca494024() Unknown
user32.dll!00007ffaed735c0d() Unknown
user32.dll!00007ffaed7357dc() Unknown
user32.dll!00007ffaed741f73() Unknown
ntdll.dll!00007ffaef61fe34() Unknown
win32u.dll!00007ffaed0d1184() Unknown
user32.dll!00007ffaed735279() Unknown
user32.dll!00007ffaed734f88() Unknown
Windows.UI.Xaml.dll!00007ffaca5f501c() Unknown
Windows.UI.Xaml.dll!00007ffaca55a9de() Unknown
Windows.UI.Xaml.dll!00007ffaca55a3fa() Unknown
Windows.UI.Xaml.dll!00007ffaca8bd730() Unknown
Windows.UI.Xaml.dll!00007ffaca8bc278() Unknown
Windows.UI.Xaml.dll!00007ffaca8bd4d9() Unknown
Windows.UI.Xaml.dll!00007ffacaa283e2() Unknown
Windows.UI.Xaml.dll!00007ffacac80dc8() Unknown
Windows.UI.Xaml.dll!00007ffacac801a4() Unknown
Windows.UI.dll!00007ffacf349980() Unknown
Windows.UI.dll!00007ffacf349718() Unknown
Windows.UI.dll!00007ffacf35500a() Unknown
Windows.UI.dll!00007ffacf354aef() Unknown
Windows.UI.dll!00007ffacf35504e() Unknown
ninput.dll!00007ffae7d70ffa() Unknown
ninput.dll!00007ffae7d6df77() Unknown
ninput.dll!00007ffae7d8ba57() Unknown
ninput.dll!00007ffae7d8ba22() Unknown
ninput.dll!00007ffae7d8b1e6() Unknown
ninput.dll!00007ffae7d8b2bb() Unknown
ninput.dll!00007ffae7d89bd8() Unknown
ninput.dll!00007ffae7d6e95b() Unknown
ninput.dll!00007ffae7d6e29d() Unknown
ninput.dll!00007ffae7d6c824() Unknown
Windows.UI.dll!00007ffacf3558e8() Unknown
Windows.UI.Xaml.dll!00007ffacac7e7c6() Unknown
Windows.UI.Xaml.dll!00007ffacac7e93c() Unknown
Windows.UI.Xaml.dll!00007ffaca8bd3f8() Unknown
Windows.UI.Xaml.dll!00007ffaca8bc652() Unknown
Windows.UI.Xaml.dll!00007ffacac844c0() Unknown
Windows.UI.Xaml.dll!00007ffaca807f2a() Unknown
Windows.UI.Xaml.dll!00007ffaca5d5190() Unknown
Windows.UI.Xaml.dll!00007ffaca5d4f53() Unknown
Windows.UI.Xaml.dll!00007ffacaab41c8() Unknown
Windows.UI.Xaml.dll!00007ffacaa8eb13() Unknown
Windows.UI.Xaml.dll!00007ffaca899ac3() Unknown
Windows.UI.Xaml.dll!00007ffaca89a3b3() Unknown
InputHost.dll!00007ffaceefc30f() Unknown
InputHost.dll!00007ffaceef705f() Unknown
InputHost.dll!00007ffaceef68bc() Unknown
InputHost.dll!00007ffaceefb73d() Unknown
InputHost.dll!00007ffaceefa813() Unknown
InputHost.dll!00007ffaceef9faa() Unknown
InputHost.dll!00007ffacef02a81() Unknown
InputHost.dll!00007ffacef0f060() Unknown
InputHost.dll!00007ffacef0d239() Unknown
InputHost.dll!00007ffacef0e1d6() Unknown
InputHost.dll!00007ffacef0e814() Unknown
InputHost.dll!00007ffacef11c78() Unknown
InputHost.dll!00007ffacef11bb2() Unknown
user32.dll!00007ffaed735c0d() Unknown
user32.dll!00007ffaed735602() Unknown
00007ffa10f8869e() Unknown
WindowsBase.dll!00007ffa6ebba25c() Unknown
WindowsBase.dll!00007ffa6ebb7801() Unknown
WindowsBase.dll!00007ffa6ebb77ae() Unknown
PresentationFramework.dll!00007ffa6f3ce84c() Unknown
PresentationFramework.dll!00007ffa6f3cce61() Unknown
PresentationFramework.dll!00007ffa6f3c9e3c() Unknown
00007ffa10a916fa() Unknown
coreclr.dll!00007ffa705b6b63() Unknown
coreclr.dll!00007ffa7054cb62() Unknown
coreclr.dll!00007ffa70553b29() Unknown
coreclr.dll!00007ffa70553fb7() Unknown
coreclr.dll!00007ffa70554761() Unknown
coreclr.dll!00007ffa704721c1() Unknown
hostpolicy.dll!00007ffa75374e2d() Unknown
hostpolicy.dll!00007ffa75382e27() Unknown
hostpolicy.dll!00007ffa75382a36() Unknown
hostpolicy.dll!00007ffa75384262() Unknown
hostfxr.dll!00007ffa757b0653() Unknown
hostfxr.dll!00007ffa757b37c8() Unknown
hostfxr.dll!00007ffa757b27cd() Unknown
hostfxr.dll!00007ffa757b027c() Unknown
hostfxr.dll!00007ffa757abd0c() Unknown
Microsoft.PowerToys.Settings.UI.Runner.exe!00007ff67e0f189f() Unknown
Microsoft.PowerToys.Settings.UI.Runner.exe!00007ff67e0f1c38() Unknown
Microsoft.PowerToys.Settings.UI.Runner.exe!00007ff67e0f3ae8() Unknown
kernel32.dll!00007ffaed647bd4() Unknown
ntdll.dll!00007ffaef5eced1() Unknown |
enricogior
reviewed
Mar 26, 2020
src/core/Microsoft.PowerToys.Settings.UI.Runner/MainWindow.xaml.cs
Outdated
Show resolved
Hide resolved
thanks I will look at it now. |
Hi Enrico, i just pulled the changes afresh and re-ran the code and it works on my machine. Can you try applying the following VS configurations and let me know it it helps: https://www.privfile.com/download.php?fid=5e7cee1e47b4f-Mzg1 |
Trying installing .Net Core 3.1 too. |
Can you verify if the following file exists: C:\Users<your user name>\AppData\Local\Microsoft\PowerToys\File Explorer Preview\settings.json |
I fixed it here: 6604c2d |
Co-Authored-By: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>
crutkas
changed the title
|
everyone, to be crisp, the decision was to just not have the new vs old toggle switch for UX, not have a breaking change. Incase something doesn't land, we still have the old UX to fall back on then. |
ghost
pushed a commit
that referenced
this pull request
Apr 7, 2020
* added power preview settings * Added link to module oververview * create settings file if one is not found * removed run oon start up speficic callback * Update src/core/Microsoft.PowerToys.Settings.UI.Lib/ModuleSettings.cs Co-Authored-By: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com> * fixed merge conflicts Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>
ghost
pushed a commit
that referenced
this pull request
Apr 7, 2020
* added power preview settings * Added link to module oververview * create settings file if one is not found * removed run oon start up speficic callback * Update src/core/Microsoft.PowerToys.Settings.UI.Lib/ModuleSettings.cs Co-Authored-By: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com> * fixed merge conflicts Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
References
PR Checklist
Validation Steps Performed